[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Fwd: Re: Broken Code Highlighting in KDevelop
From:       Christoph Cullmann <christoph () cullmann ! io>
Date:       2021-02-18 17:03:57
Message-ID: f94690e8d34ecf85be2a53f2f06300b9 () cullmann ! io
[Download RAW message or body]

On 2021-02-18 09:45, David Redondo wrote:
> Am Mittwoch, 17. Februar 2021, 16:11:58 CET schrieben Sie:
>> 
>> No idea.
>> 
>> I only know that without these fix, you can run into invalid
>> hashed/cached ranges,
>> see the matching unit test
>> 
>> https://invent.kde.org/frameworks/ktexteditor/-/commit/eb42f8903da9b04a070ec
>> b20a9ec42686e27d7b1
>> 
>> Perhaps this change is not 100% correct, but then somebody must try
>> to figure out why ;=)
> Seems like you did :D
> With https://invent.kde.org/frameworks/ktexteditor/-/commit/
> 686da7797105a93035cfbc7edbf2a8e8f8adf0ec back to working correctly.

Yeah, should be fixed and it has an unit test now, to
at least not break this trivially again.

Now the original reason for this change (segfault due to invalid 
pointers)
& the caching aspect should work again, both unit tested.

Greetings
Christoph

> 
>> Greetings
>> Christoph
>> 
> Thanks for the awesome work,
> David

-- 
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org
[prev in list] [next in list] [prev in thread] [next in thread]