[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Changes to "schema" aka "color theme" handling
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2020-09-13 14:44:23
Message-ID: CALi_srC+omi+uu1=r48hXz4R0oMbmyAHhjr7ga_ceXz6SUTsiQ () mail ! gmail ! com
[Download RAW message or body]

Hi Christoph,

very well done :)

I btw just got another idea:
We could add things like SPDX-FileCopyrightText or SPDX-LicenseIdentifier
etc. to either Alerts.xml or Doxygen.xml. Then we'd have nice highlighting
for this as well.

Best regards
Dominik




Christoph Cullmann <christoph@cullmann.io> schrieb am So., 13. Sep. 2020,
15:26:

> On 2020-09-10 22:28, Christoph Cullmann wrote:
> > Hi,
> > 
> > https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/21
> > 
> > should now work.
> 
> This got now merged.
> 
> I did some further code cleanups afterwards and some more internal
> "schema" => "theme" renamings.
> 
> More testing + fixes + new themes are appreciated .P
> 
> For more details, I wrote
> https://kate-editor.org/post/2020/2020-09-13-kate-color-themes-5.75/
> 
> Greetings
> Christoph
> 
> > 
> > If somebody could give this some testing, that would be appreciated.
> > 
> > You need latest master syntax-highlighting due to some bugfixing + the
> > branch of
> > that request.
> > 
> > Feedback (+ fixes) appreciated.
> > 
> > Greetings
> > Christoph
> > 
> > On 2020-09-07 23:16, Christoph Cullmann wrote:
> > > Hi,
> > > 
> > > the first part of this stuff is now merged.
> > > 
> > > In
> > > 
> > > https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/21
> > > 
> > > I am working on completely removing the old schema stuff and only
> > > using KTextEditor::Theme
> > > as basis for the coloring.
> > > 
> > > The actual usage is already OK, the remaining missing pieces is the
> > > saving of the configuration
> > > as JSON files.
> > > 
> > > Any help (and testing) welcome!
> > > 
> > > Just ping me in the merge request.
> > > 
> > > Greetings
> > > Christoph
> > > 
> > > On 2020-09-02 22:24, Christoph Cullmann wrote:
> > > > KTextEditor uses since long the KSyntaxHighlighting framework to
> > > > provide the highlighting instead it's old own code.
> > > > 
> > > > But for the coloring, we bypassed all stuff provided by this
> > > > framework.
> > > > 
> > > > For the frameworks release in October I want to change this and
> > > > switch
> > > > over to the color themes as provided by KSyntaxHighlighting (but
> > > > still
> > > > allow to configure them like now via the GUI and provide own ones in
> > > > the "old" style).
> > > > 
> > > > The matching merge request is:
> > > > 
> > > > https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/20
> > > > 
> > > > If you have some time to test this, feel welcome!
> > > > 
> > > > Beside that, it would make sense to provide some more bundled themes
> > > > (if available as MIT licensed stuff), see this development issue for
> > > > some potential candidates:
> > > > 
> > > > https://invent.kde.org/frameworks/syntax-highlighting/-/issues/2
> > > > 
> > > > Contributors welcome ;=)
> > > > 
> > > > The stuff must end up as JSON file in
> > > > 
> https://invent.kde.org/frameworks/syntax-highlighting/-/tree/master/data/themes
> > > > 
> > > > kate-editor.org will provide some auto-generated overview with
> > > > example
> > > > renderings, like we do already for the syntax highlightings:
> > > > 
> > > > https://kate-editor.org/themes/
> > > > 
> > > > (that stuff is generated via
> > > > '
> https://invent.kde.org/frameworks/syntax-highlighting/-/blob/master/data/generators/update-kate-editor-org.pl
>  ',
> > > > improvements welcome, too)
> > > > 
> > > > Greetings
> > > > Christoph
> 
> --
> Ignorance is bliss...
> https://cullmann.io | https://kate-editor.org
> 


[Attachment #3 (text/html)]

<div dir="auto"><div>Hi Christoph,<div dir="auto"><br></div><div dir="auto">very well \
done :)</div><div dir="auto"><br></div><div dir="auto">I btw just got another \
idea:</div><div dir="auto">We could add things like SPDX-FileCopyrightText or \
SPDX-LicenseIdentifier etc. to either Alerts.xml or Doxygen.xml. Then we&#39;d have \
nice highlighting for this as well.</div></div><div dir="auto"><br></div><div \
dir="auto">Best regards</div><div dir="auto">Dominik</div><div \
dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><br><br><div \
class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">Christoph Cullmann \
&lt;<a href="mailto:christoph@cullmann.io">christoph@cullmann.io</a>&gt; schrieb am \
So., 13. Sep. 2020, 15:26:<br></div><blockquote class="gmail_quote" style="margin:0 0 \
0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 2020-09-10 22:28, Christoph \
Cullmann wrote:<br> &gt; Hi,<br>
&gt; <br>
&gt; <a href="https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/21" \
rel="noreferrer noreferrer" \
target="_blank">https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/21</a><br>
 &gt; <br>
&gt; should now work.<br>
<br>
This got now merged.<br>
<br>
I did some further code cleanups afterwards and some more internal <br>
&quot;schema&quot; =&gt; &quot;theme&quot; renamings.<br>
<br>
More testing + fixes + new themes are appreciated .P<br>
<br>
For more details, I wrote <br>
<a href="https://kate-editor.org/post/2020/2020-09-13-kate-color-themes-5.75/" \
rel="noreferrer noreferrer" \
target="_blank">https://kate-editor.org/post/2020/2020-09-13-kate-color-themes-5.75/</a><br>
 <br>
Greetings<br>
Christoph<br>
<br>
&gt; <br>
&gt; If somebody could give this some testing, that would be appreciated.<br>
&gt; <br>
&gt; You need latest master syntax-highlighting due to some bugfixing + the <br>
&gt; branch of<br>
&gt; that request.<br>
&gt; <br>
&gt; Feedback (+ fixes) appreciated.<br>
&gt; <br>
&gt; Greetings<br>
&gt; Christoph<br>
&gt; <br>
&gt; On 2020-09-07 23:16, Christoph Cullmann wrote:<br>
&gt;&gt; Hi,<br>
&gt;&gt; <br>
&gt;&gt; the first part of this stuff is now merged.<br>
&gt;&gt; <br>
&gt;&gt; In<br>
&gt;&gt; <br>
&gt;&gt; <a href="https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/21" \
rel="noreferrer noreferrer" \
target="_blank">https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/21</a><br>
 &gt;&gt; <br>
&gt;&gt; I am working on completely removing the old schema stuff and only<br>
&gt;&gt; using KTextEditor::Theme<br>
&gt;&gt; as basis for the coloring.<br>
&gt;&gt; <br>
&gt;&gt; The actual usage is already OK, the remaining missing pieces is the<br>
&gt;&gt; saving of the configuration<br>
&gt;&gt; as JSON files.<br>
&gt;&gt; <br>
&gt;&gt; Any help (and testing) welcome!<br>
&gt;&gt; <br>
&gt;&gt; Just ping me in the merge request.<br>
&gt;&gt; <br>
&gt;&gt; Greetings<br>
&gt;&gt; Christoph<br>
&gt;&gt; <br>
&gt;&gt; On 2020-09-02 22:24, Christoph Cullmann wrote:<br>
&gt;&gt;&gt; KTextEditor uses since long the KSyntaxHighlighting framework to<br>
&gt;&gt;&gt; provide the highlighting instead it&#39;s old own code.<br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; But for the coloring, we bypassed all stuff provided by this <br>
&gt;&gt;&gt; framework.<br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; For the frameworks release in October I want to change this and <br>
&gt;&gt;&gt; switch<br>
&gt;&gt;&gt; over to the color themes as provided by KSyntaxHighlighting (but <br>
&gt;&gt;&gt; still<br>
&gt;&gt;&gt; allow to configure them like now via the GUI and provide own ones in<br>
&gt;&gt;&gt; the &quot;old&quot; style).<br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; The matching merge request is:<br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; <a href="https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/20" \
rel="noreferrer noreferrer" \
target="_blank">https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/20</a><br>
 &gt;&gt;&gt; <br>
&gt;&gt;&gt; If you have some time to test this, feel welcome!<br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; Beside that, it would make sense to provide some more bundled themes<br>
&gt;&gt;&gt; (if available as MIT licensed stuff), see this development issue for<br>
&gt;&gt;&gt; some potential candidates:<br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; <a href="https://invent.kde.org/frameworks/syntax-highlighting/-/issues/2" \
rel="noreferrer noreferrer" \
target="_blank">https://invent.kde.org/frameworks/syntax-highlighting/-/issues/2</a><br>
 &gt;&gt;&gt; <br>
&gt;&gt;&gt; Contributors welcome ;=)<br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; The stuff must end up as JSON file in<br>
&gt;&gt;&gt; <a href="https://invent.kde.org/frameworks/syntax-highlighting/-/tree/master/data/themes" \
rel="noreferrer noreferrer" \
target="_blank">https://invent.kde.org/frameworks/syntax-highlighting/-/tree/master/data/themes</a><br>
 &gt;&gt;&gt; <br>
&gt;&gt;&gt; <a href="http://kate-editor.org" rel="noreferrer noreferrer" \
target="_blank">kate-editor.org</a> will provide some auto-generated overview with \
<br> &gt;&gt;&gt; example<br>
&gt;&gt;&gt; renderings, like we do already for the syntax highlightings:<br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; <a href="https://kate-editor.org/themes/" rel="noreferrer noreferrer" \
target="_blank">https://kate-editor.org/themes/</a><br> &gt;&gt;&gt; <br>
&gt;&gt;&gt; (that stuff is generated via<br>
&gt;&gt;&gt; &#39;<a \
href="https://invent.kde.org/frameworks/syntax-highlighting/-/blob/master/data/generators/update-kate-editor-org.pl" \
rel="noreferrer noreferrer" \
target="_blank">https://invent.kde.org/frameworks/syntax-highlighting/-/blob/master/data/generators/update-kate-editor-org.pl</a>&#39;,<br>
 &gt;&gt;&gt; improvements welcome, too)<br>
&gt;&gt;&gt; <br>
&gt;&gt;&gt; Greetings<br>
&gt;&gt;&gt; Christoph<br>
<br>
-- <br>
Ignorance is bliss...<br>
<a href="https://cullmann.io" rel="noreferrer noreferrer" \
target="_blank">https://cullmann.io</a> | <a href="https://kate-editor.org" \
rel="noreferrer noreferrer" target="_blank">https://kate-editor.org</a><br> \
</blockquote></div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic