[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: kate stopped warning about changed files (but only C++ files)
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2020-02-23 16:18:05
Message-ID: 1811466.PYKUYFuaPT () xps
[Download RAW message or body]

El diumenge, 23 de febrer de 2020, a les 13:43:00 CET, Dominik Haumann va escriure:
> Hi,
> 
> facts:
> - the feature is there on purpose and useful to many users (other editors
> do the same)

Lots of people may like this behaviour, but I think it goes against the principle of \
least surprise. Sometimes a file changes externally and kate shows a dialog, \
sometimes it does not, and as far as i can see that behaviour is not documented \
anywhere, so why would anyone think it's a feature and not a bug?

Can we please get the feature documented in the handbook? I guess maybe as part of \
"Warn about files modified by foreign processes"? \
https://docs.kde.org/stable5/en/applications/kate/config-dialog.html#config-dialog-general


> - kate is not a replacement for a version control system

Totally agreed, and I am not asking it to be. Actually if you ask me, that special \
casing of git is making kate try to be a version control system, what we both seem to \
agree it should not.


> - still, there seem to be corner cases where the current behavior is not
> desirable
> 
> Turning this into action: Albert, please provide a patch to make this
> optional.

I guess i can put it in my infinite TODO queue, but I need somebody to give me a one \
sentence description of what the actual behaviour is so i can put it in the \
configuration dialog. Because I can't seem to understand/summarize it enough.

Cheers,
  Albert

> 
> Best regards
> Dominik
> 
> 
> Albert Astals Cid <aacid@kde.org> schrieb am So., 23. Feb. 2020, 12:27:
> 
> > El dissabte, 22 de febrer de 2020, a les 21:06:00 CET, Sven Brauch va
> > escriure:
> > > Hi,
> > > 
> > > On Saturday, 22 February 2020 17:18:31 CET Albert Astals Cid wrote:
> > > > edit file
> > > > git commit -a
> > > > git reset --hard origin/master
> > > > the file contents are gone.
> > > > 
> > > > Yes i know that i did a git reset, but up to now kate always kept
> > things for
> > > > me, so I'm used to do that and then salvage the files i actually
> > wanted to
> > > > keep.
> > > 
> > > sorry, I don't understand the purpose of this workflow. You do changes,
> > commit
> > > them, then discard the commit by going back to origin/master and then
> > commit
> > > those you *actually* wanted again by salvaging the files from your text
> > > editor? I probably misunderstood ;)
> > 
> > No, you did not misunderstand, I do weird shit, all i am asking is for my
> > editor to not try to be a smart wannabe-clippy and just do what it's
> > supposed to do, tell me the file has changed and if i want to keep the
> > changes or not.
> > 
> > I'm really fine if i have to enable a non-default option for that.
> > 
> > Cheers,
> > Albert
> > 
> > > 
> > > Anyways, if you want to restore the contents of the file to before the
> > reset,
> > > they are still there:
> > > 
> > > git checkout HEAD@{1} -- <path/to/file>
> > > 
> > > That's why kate feels free to reload the file.
> > > 
> > > Best,
> > > Sven
> > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> > 
> 


[prev in list] [next in list] [prev in thread] [next in thread]