From kwrite-devel  Sun Feb 02 11:31:22 2020
From: Christoph Cullmann <christoph () cullmann ! io>
Date: Sun, 02 Feb 2020 11:31:22 +0000
To: kwrite-devel
Subject: Re: Gitlab fork or branch workflow?
Message-Id: <675450009b9d4bbc4a92772c5381d775 () cullmann ! io>
X-MARC-Message: https://marc.info/?l=kwrite-devel&m=158064309332030

On 2020-02-02 11:04, Kåre Särs wrote:
> On lördag 1 februari 2020 kl. 22:35:31 EET Christoph Cullmann wrote:
>> On 2020-02-01 21:33, Kåre Särs wrote:
>> > Hi,
>> >
>> > I tried to search for the the answer to this but could not find it.
>> >
>> > What is the preferred way to make a pull-request on invent.kde.org for
>> > Kate
>> > (and other KDE projects)? Is it to create a personal fork or to create
>> > a
>> > branch in the main repo?
>> 
>> I tend to just use branches in the main repository.
>> I am not aware of some KDE wide rule for this at the moment.
> 
> I just noticed a little drawback with using branches in the main repo. 
> The
> commit message for the pull-request branch comes together with the 
> normal
> commit messages to master and stable branches. This adds noise to the 
> commit
> messages... I can add mail filters at my end, but I wonder if there 
> could be a
> filter on gitlab...

Hi,

on the other side, that leads to bit more visibility and might attract 
earlier feedback.

Not sure if that can be configured on the GitLab side.

At the moment I would not mind the extra mails myself.

Btw., merged your request, good catch!
Cherry-picked it to 19.12, too.

Greetings
Christoph

-- 
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org