[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    D23457: Port the search interface from QRegExp to QRegularExpression
From:       Ahmad Samir <noreply () phabricator ! kde ! org>
Date:       2020-01-26 12:08:55
Message-ID: 0c94d672321ade42e3da3b9e29baa400 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ahmadsamir updated this revision to Diff 74387.
ahmadsamir added a comment.


  - Rebase
  - Match the old code and check if the pattern is empty, this lets the \
vimode_emulatedcommandbar unit test pass

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23457?vs=71618&id=74387

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23457

AFFECTED FILES
  autotests/src/regexpsearch_test.cpp
  autotests/src/searchbar_test.cpp
  src/CMakeLists.txt
  src/document/katedocument.cpp
  src/search/kateplaintextsearch.cpp
  src/search/kateregexp.cpp
  src/search/kateregexp.h
  src/search/kateregexpsearch.cpp
  src/search/kateregexpsearch.h
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/utils/katesedcmd.cpp
  src/utils/katesedcmd.h

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, GB_2, domson, michaelh, \
ngraham, bruns, demsking, cullmann, sars, dhaumann


[Attachment #3 (text/html)]

<table><tr><td style="">ahmadsamir updated this revision to Diff 74387.<br \
/>ahmadsamir added a comment. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D23457">View Revision</a></tr></table><br \
/><div><div><ul class="remarkup-list"> <li class="remarkup-list-item">Rebase</li>
<li class="remarkup-list-item">Match the old code and check if the pattern is empty, \
this lets the vimode_emulatedcommandbar unit test pass</li> </ul></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br \
/><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D23457?vs=71618&amp;id=74387">https://phabricator.kde.org/D23457?vs=71618&amp;id=74387</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>l-qregularexpression (branched from \
master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D23457">https://phabricator.kde.org/D23457</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>autotests/src/regexpsearch_test.cpp<br /> \
autotests/src/searchbar_test.cpp<br /> src/CMakeLists.txt<br />
src/document/katedocument.cpp<br />
src/search/kateplaintextsearch.cpp<br />
src/search/kateregexp.cpp<br />
src/search/kateregexp.h<br />
src/search/kateregexpsearch.cpp<br />
src/search/kateregexpsearch.h<br />
src/search/katesearchbar.cpp<br />
src/search/katesearchbar.h<br />
src/utils/katesedcmd.cpp<br />
src/utils/katesedcmd.h</div></div></div><br /><div><strong>To: </strong>ahmadsamir, \
KTextEditor, dhaumann, cullmann<br /><strong>Cc: </strong>kde-frameworks-devel, \
kwrite-devel, rrosch, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, \
cullmann, sars, dhaumann<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]