--Sig_/81CXSDr9Kz81gP5cGN2JCQY
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 16 Jan 2020 20:29:48 +0100
Christoph Cullmann <christoph@cullmann.io> wrote:
> On 2020-01-16 10:36, Thomas Friedrichsmeier wrote:
[...]
> > However, there are still some advantages over the current approach:
> > 1) *Existing* functions can be offered as virtuals in the
> > "host-facing" MainWindowImpl in KF6, allowing for:
> > 1a) having default implementations in the base-class, where
> > possible. Perhaps e.g. for (read/write)SessionConfig, or findUrl().
> > 1b) build-time sanity checks
> > 1c) better performance (probably irrelevant)
> > 2) This would also give a reasonable place where to provide
> > shareable "host-facing" functionality such as (repeat):
> >   - loading/unloading a plugin by id, all complete with
> > bookkeeping, and
> >     signals
> >   - keeping track of views / toolviews / other resources "owned" by
> > a plugin, and emitting the signals for that
> >=20
> > *New* functions could still be added the same way as now: The
> > "plugin-facing" MainWindow (tries to) call a slot in its
> > "host-facing" parent. No change, here, other than that the parent
> > happens to inherit from MainWindowImpl, rather than plain QObject. =20
>=20
> I think I would have no issues with such an approach, that we just
> have the "initial" stuff in KF6 via virtual functions and just extend
> the interface with our "hack" if the need arises.

... but you don't sound quite convinced, either. To clarify, this
suggestion is not something that will enable me to do anything new in
RKWard. It's an idea to make the interface cleaner. If it doesn't
achieve that - and you have much more expertise in judging that - then
it's no use. So don't be shy to give it a no-go, just because I seem
fond of the idea ;-)

Either way, one thing that I would really like to see, is bringing
(most of) the functionality in KatePluginManager into KTextEditor,
somehow. With my suggestion, I think the obvious place for that would
be KTextEditor::ApplicationImpl (or whatever it would be called).
Without my suggestion, where should it go?

Regards
Thomas

--Sig_/81CXSDr9Kz81gP5cGN2JCQY
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEby3AwIMM6jiQ/yLPORWR3xhYy7YFAl4jcTMACgkQORWR3xhY
y7Zw2Q//R57y6eFTnLF/MFmuZC1Mj46wZi0DVF3lPDzViYHMW//2xGEpbWMeLhqn
Ku7UITIKLMPxglytr/WWqotZT//Ck/UFrfm3x24/9WDCOpOwyN1GkL77nnEuPpUV
OJ9s3xLQDzT0ceSi2Vm3KyUYo09MF8qbE+Qjyr6MeWHXPKtDoOmjBfhG5cBTNdCY
5sEWp9uqUiYcqbw7HdyTExOKkukSoyDhRb5QYCKrDWNOooL5QXwQmFd+YVGaK18R
FdxeQt4AvrBtO0fAClp1+i5XD+nrmX3p5HtKe061lZZH5kvE2cC49i/2jCZyibXS
Vvi97w2I94e9wUIhFjhgtTu5oirbo6xV1ocX9RYALAvMKsPg0P5UqfCsZD9+TwVy
HcfTM8ZhI/eM+ZD5r3rjAQZqpwQNwco3YyQdMx8OfS7cMLQwm6Kg++01UTzGL1eW
VNwiUAMARVmVY095Jhu69rX7EF3AFvPPWNvN22Wdy0t32bOtGVNDo+mMV6KZvBRI
zY9zVTLxBA2+Xio9iKhtpemcV4SpO7rEFCYQbqWpf2dDfxx1CpInKqxFPu3PlKMW
X1iI8sYtacYrPz+9US3DFvqPYwRsvjHNnddDMXki7xfJ8Dman9KBueqX+2eUuK+F
eoJE97EE+PqxAYI+jW/639PGs8HziHp3gPuC97nyhPM1vA/A6xw=
=sIwP
-----END PGP SIGNATURE-----

--Sig_/81CXSDr9Kz81gP5cGN2JCQY--