[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: kate clang-format
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2019-10-06 12:15:44
Message-ID: CALi_srAnfqMV02PE1ayeEBb36+NFJdmLz-9So0-w6MoZ-GLYSg () mail ! gmail ! com
[Download RAW message or body]

Direct push is typically Christoph and me. But I don't see that a big
issue: feel free to run clang-format any time.

Best regards
Dominik

Christoph Cullmann <christoph@cullmann.io> schrieb am So., 6. Okt. 2019,
13:47:

> On 2019-10-06 13:29, Albert Astals Cid wrote:
> > El diumenge, 6 d'octubre de 2019, a les 13:17:54 CEST, Mark
> > Nauwelaerts va escriure:
> >> Hi All,
> >>
> >> Recently a .clang-format file was added to kate repo along with a
> >> reformat.sh
> >> helper script to suitably format all files. However, applying the
> >> latter script
> >> (again) shows a diff, where presumably the ideal intention is that
> >> there is no diff.
> >>
> >> So, maybe some sort of format/linting should or could be added?
> >> Perhaps by means
> >> of a git-commit hook, or some automated job (like translations) that
> >> auto-formats in case some author did not format accordingly?
> >
> > Since kate is in invent.kde.org a CI job that makes sure the
> > formatting is correct is the solution.
> >
> > That way no commit will go in without being checked.
> >
> > Except for the people that do direct pushes ;)
>
> CI support would be great.
>
> At the moment just feel free to push the reformat commit.
>
> Greetings
> Christoph
>
> >
> > Cheers,
> >   Albert
> >
> >>
> >> Regards,
> >> Mark
> >>
>
> --
> Ignorance is bliss...
> https://cullmann.io | https://kate-editor.org
>

[Attachment #3 (text/html)]

<div dir="auto">Direct push is typically Christoph and me. But I don&#39;t see that a \
big issue: feel free to run clang-format any time.<div dir="auto"><br></div><div \
dir="auto">Best regards</div><div dir="auto">Dominik</div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">Christoph Cullmann &lt;<a \
href="mailto:christoph@cullmann.io">christoph@cullmann.io</a>&gt; schrieb am So., 6. \
Okt. 2019, 13:47:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">On 2019-10-06 13:29, Albert Astals \
Cid wrote:<br> &gt; El diumenge, 6 d'octubre de 2019, a les 13:17:54 CEST, Mark<br>
&gt; Nauwelaerts va escriure:<br>
&gt;&gt; Hi All,<br>
&gt;&gt; <br>
&gt;&gt; Recently a .clang-format file was added to kate repo along with a <br>
&gt;&gt; reformat.sh<br>
&gt;&gt; helper script to suitably format all files. However, applying the <br>
&gt;&gt; latter script<br>
&gt;&gt; (again) shows a diff, where presumably the ideal intention is that <br>
&gt;&gt; there is no diff.<br>
&gt;&gt; <br>
&gt;&gt; So, maybe some sort of format/linting should or could be added? <br>
&gt;&gt; Perhaps by means<br>
&gt;&gt; of a git-commit hook, or some automated job (like translations) that<br>
&gt;&gt; auto-formats in case some author did not format accordingly?<br>
&gt; <br>
&gt; Since kate is in <a href="http://invent.kde.org" rel="noreferrer noreferrer" \
target="_blank">invent.kde.org</a> a CI job that makes sure the<br> &gt; formatting \
is correct is the solution.<br> &gt; <br>
&gt; That way no commit will go in without being checked.<br>
&gt; <br>
&gt; Except for the people that do direct pushes ;)<br>
<br>
CI support would be great.<br>
<br>
At the moment just feel free to push the reformat commit.<br>
<br>
Greetings<br>
Christoph<br>
<br>
&gt; <br>
&gt; Cheers,<br>
&gt;     Albert<br>
&gt; <br>
&gt;&gt; <br>
&gt;&gt; Regards,<br>
&gt;&gt; Mark<br>
&gt;&gt; <br>
<br>
-- <br>
Ignorance is bliss...<br>
<a href="https://cullmann.io" rel="noreferrer noreferrer" \
target="_blank">https://cullmann.io</a> | <a href="https://kate-editor.org" \
rel="noreferrer noreferrer" target="_blank">https://kate-editor.org</a><br> \
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]