[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Rust Completion Plugin
From:       Eike Hein <hein () kde ! org>
Date:       2019-08-21 20:20:07
Message-ID: D919D122-A903-4DDF-A673-579BCF304CC2 () kde ! org
[Download RAW message or body]

Hi Dominik,

I would support this - my plugin is based on racer, and the language server \
protocol and RLS were basically born to do one better. racer is used in \
RLS. It's the right way to go as far as I'm concerned. Quite happy the LPS \
plugin happened :)

I'd even accept a hard handover without a grace period; the plugin probably \
doesn't see a lot of use at this point, and racer users can migrate to RLS.

Cheers,
Eike

On August 22, 2019 4:21:03 AM GMT+09:00, Dominik Haumann <dhaumann@kde.org> \
wrote:
> Hi Eike and everyone,
> 
> since 2015 Kate got the rustcompletion plugin:
> https://invent.kde.org/kde/kate/commits/master/addons/rustcompletion
> 
> Recently, the lsp plugin was added with Rust support:
> -
> https://kate-editor.org/post/2019-08-07-kate-initial-rust-lsp-support/
> -
> https://kate-editor.org/post/2019/2019-08-10-kate-lsp-more-languages-supported/
>  
> Eike, would it make sense to remove your plugin in favor of the lsp
> plugin?
> As far as I understand, the rustcompletion plugin "just" supports code
> completion and goto definition. The LPS plugin supports this as well
> and
> likely more.
> 
> Maybe we should have a smooth migration path: For the 19.12 release,
> still
> ship both plugins, but for 20.04 drop the rustcompletion plugin.
> 
> Maybe something we can discuss at Akademy. Thoughts?
> 
> Best regards
> Dominik

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


[Attachment #3 (text/html)]

<html><head></head><body>Hi Dominik,<br><br>I would support this - my \
plugin is based on racer, and the language server protocol and RLS were \
basically born to do one better. racer is used in RLS. It's the right way \
to go as far as I'm concerned. Quite happy the LPS plugin happened \
:)<br><br>I'd even accept a hard handover without a grace period; the \
plugin probably doesn't see a lot of use at this point, and racer users can \
migrate to RLS.<br><br>Cheers,<br>Eike<br><br><div class="gmail_quote">On \
August 22, 2019 4:21:03 AM GMT+09:00, Dominik Haumann \
&lt;dhaumann@kde.org&gt; wrote:<blockquote class="gmail_quote" \
style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, \
204); padding-left: 1ex;"> <div dir="ltr"><div>Hi Eike and \
everyone,</div><div><br></div><div>since 2015 Kate got the rustcompletion \
plugin:<br></div><div><a \
href="https://invent.kde.org/kde/kate/commits/master/addons/rustcompletion"> \
https://invent.kde.org/kde/kate/commits/master/addons/rustcompletion</a></div><div><br></div><div>Recently, \
the lsp plugin was added with Rust support:</div><div>- <a \
href="https://kate-editor.org/post/2019-08-07-kate-initial-rust-lsp-support/ \
">https://kate-editor.org/post/2019-08-07-kate-initial-rust-lsp-support/</a></div><div>- \
<a href="https://kate-editor.org/post/2019/2019-08-10-kate-lsp-more-language \
s-supported/">https://kate-editor.org/post/2019/2019-08-10-kate-lsp-more-languages-supported/</a></div><div><br></div><div>Eike, \
would it make sense to remove your plugin in favor of the lsp plugin? As \
far as I understand, the rustcompletion plugin "just" supports code \
completion and goto definition. The LPS plugin supports this as well and \
likely more.</div><div><br></div><div>Maybe we should have a smooth \
migration path: For the 19.12 release, still ship both plugins, but for \
20.04 drop the rustcompletion plugin.</div><div><br></div><div>Maybe \
something we can discuss at Akademy. \
Thoughts?</div><div><br></div><div>Best \
regards</div><div>Dominik<br></div></div> </blockquote></div><br>-- \
<br>Sent from my Android device with K-9 Mail. Please excuse my \
brevity.</body></html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic