[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: CMake style
From: Daan De Meyer <daan.j.demeyer () gmail ! com>
Date: 2019-07-24 13:11:30
Message-ID: CAO8sHcm+T85ggiBnGhvWauV+wEduUNTtcGs4STMF7-MF6oXFaQ () mail ! gmail ! com
[Download RAW message or body]
I agree, I'll upload it in two parts later today, one with all the addons
changes and another one with the changes to kwrite and kate.
Regards,
Daan
On Wed, 24 Jul 2019 at 15:01, Christoph Cullmann <christoph@cullmann.io>
wrote:
> On 2019-07-24 12:43, Daan De Meyer wrote:
> > I agree that passing the version via the command line might be a bit
> > excessive. However, by moving the other defines out of the config.h,
> > we can only specify them for the targets that actually use them which
> > feels like an improvement to me. I'll keep the config file to store
> > the version but maybe it should be renamed to version.h to more
> > accurately reflect its contents now.
>
> Perhaps it would make sense to share the diff via phabricator to see
> the current state and if the direction is ok.
>
> Greetings
> Christoph
>
> >
> > Regards,
> >
> > Daan
> >
> > On Wed, 24 Jul 2019 at 11:23, Alex Turbov <i.zaufi@gmail.com> wrote:
> >
> >> Hi,
> >>
> >> On Wed, Jul 24, 2019 at 10:38 AM Daan De Meyer
> >> <daan.j.demeyer@gmail.com> wrote:
> >>
> >>> The KATE_VERSION variable was used in some source files but by
> >>> passing the version as a command line define via CMake allowed me
> >>> to remove the config.h file completely.
> >>
> >> The good practice IMO is completely opposite: move `#defines` from
> >> CLI to generated `*.h` file(s) as much as you can. As for me, it'll
> >> make the CLI shorter and readable by humans w/ less pain. But the
> >> main reason: various shells have different limitations on CI
> >> length...
>
> --
> Ignorance is bliss...
> https://cullmann.io | https://kate-editor.org
>
[Attachment #3 (text/html)]
<div dir="ltr"><div>I agree, I'll upload it in two parts later today, one with \
all the addons changes and another one with the changes to kwrite and \
kate.</div><div><br></div><div>Regards,</div><div><br></div><div>Daan<br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 24 Jul 2019 at 15:01, \
Christoph Cullmann <<a \
href="mailto:christoph@cullmann.io">christoph@cullmann.io</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2019-07-24 12:43, \
Daan De Meyer wrote:<br> > I agree that passing the version via the command line \
might be a bit<br> > excessive. However, by moving the other defines out of the \
config.h,<br> > we can only specify them for the targets that actually use them \
which<br> > feels like an improvement to me. I'll keep the config file to \
store<br> > the version but maybe it should be renamed to version.h to more<br>
> accurately reflect its contents now.<br>
<br>
Perhaps it would make sense to share the diff via phabricator to see<br>
the current state and if the direction is ok.<br>
<br>
Greetings<br>
Christoph<br>
<br>
> <br>
> Regards,<br>
> <br>
> Daan<br>
> <br>
> On Wed, 24 Jul 2019 at 11:23, Alex Turbov <<a href="mailto:i.zaufi@gmail.com" \
target="_blank">i.zaufi@gmail.com</a>> wrote:<br> > <br>
>> Hi,<br>
>> <br>
>> On Wed, Jul 24, 2019 at 10:38 AM Daan De Meyer<br>
>> <<a href="mailto:daan.j.demeyer@gmail.com" \
target="_blank">daan.j.demeyer@gmail.com</a>> wrote:<br> >> <br>
>>> The KATE_VERSION variable was used in some source files but by<br>
>>> passing the version as a command line define via CMake allowed me<br>
>>> to remove the config.h file completely.<br>
>> <br>
>> The good practice IMO is completely opposite: move `#defines` from<br>
>> CLI to generated `*.h` file(s) as much as you can. As for me, it'll<br>
>> make the CLI shorter and readable by humans w/ less pain. But the<br>
>> main reason: various shells have different limitations on CI<br>
>> length...<br>
<br>
-- <br>
Ignorance is bliss...<br>
<a href="https://cullmann.io" rel="noreferrer" \
target="_blank">https://cullmann.io</a> | <a href="https://kate-editor.org" \
rel="noreferrer" target="_blank">https://kate-editor.org</a><br> </blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic