[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    D18617: AsciiDoc: Fix highlighting of include directive
From:       Andreas Gratzer <noreply () phabricator ! kde ! org>
Date:       2019-01-31 5:43:17
Message-ID: 192287725ea74f8061f9538670196885 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

andreasgr added a comment.


  In D18617#402600 <https://phabricator.kde.org/D18617#402600>, @dhaumann wrote:
  
  > Looks good to me. Please increase the "version" number whenever you change an \
highlighting file.  
  
  Ooops, sorry.
  Many thanks for the quick review.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18617

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, \
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann


[Attachment #3 (text/html)]

<table><tr><td style="">andreasgr added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D18617">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D18617#402600" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D18617#402600</a>, <a \
href="https://phabricator.kde.org/p/dhaumann/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@dhaumann</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Looks good to me. Please increase the \
&quot;version&quot; number whenever you change an highlighting file.</p></div> \
</blockquote>

<p>Ooops, sorry.<br />
Many thanks for the quick review.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R216 Syntax \
Highlighting</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D18617">https://phabricator.kde.org/D18617</a></div></div><br \
/><div><strong>To: </strong>andreasgr, Framework: Syntax Highlighting, dhaumann<br \
/><strong>Cc: </strong>kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, \
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]