[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    D17891: WML: fix infinite loop in contexts switch & only highlight tags with valid names
From:       Nibaldo_González <noreply () phabricator ! kde ! org>
Date:       2019-01-02 7:47:04
Message-ID: 1d56c3369fcec5a13f89396022ff88f5 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

nibags updated this revision to Diff 48510.
nibags added a comment.


  - Update
  
  I asked in the thread of the Wesnoth forum, that appears in the `wml.xml` file \
(http://www.wesnoth.org/forum/viewtopic.php?f=21&t=13781), if the changes are OK and someone has \
suggested to me that the array indices (`array[0]`) aren't highlighted as tags, as well that I included \
it  
  Changes:
  
  - kateversion to 5.0
  - Delete commented code
  - Don't highlight tags if there is an alphanumeric character, underscore or "]" before, to avoid \
highlighting array indices as tags.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17891?vs=48465&id=48510

BRANCH
  fix-wml

REVISION DETAIL
  https://phabricator.kde.org/D17891

AFFECTED FILES
  autotests/folding/test.pbl.fold
  autotests/html/test.pbl.html
  autotests/input/test.pbl
  autotests/reference/test.pbl.ref
  data/syntax/wml.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, \
dhaumann


[Attachment #3 (text/html)]

<table><tr><td style="">nibags updated this revision to Diff 48510.<br />nibags added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; \
font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D17891">View Revision</a></tr></table><br /><div><div><ul \
class="remarkup-list"> <li class="remarkup-list-item">Update</li>
</ul>

<p>I asked in the thread of the Wesnoth forum, that appears in the <tt style="background: #ebebeb; \
font-size: 13px;">wml.xml</tt> file (<a \
href="http://www.wesnoth.org/forum/viewtopic.php?f=21&amp;t=13781" class="remarkup-link" target="_blank" \
rel="noreferrer">http://www.wesnoth.org/forum/viewtopic.php?f=21&amp;t=13781</a>), if the changes are OK \
and someone has suggested to me that the array indices (<tt style="background: #ebebeb; font-size: \
13px;">array[0]</tt>) aren&#039;t highlighted as tags, as well that I included it</p>

<p>Changes:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">kateversion to 5.0</li>
<li class="remarkup-list-item">Delete commented code</li>
<li class="remarkup-list-item">Don&#039;t highlight tags if there is an alphanumeric character, \
underscore or &quot;]&quot; before, to avoid highlighting array indices as tags.</li> \
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax \
Highlighting</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D17891?vs=48465&amp;id=48510">https://phabricator.kde.org/D17891?vs=48465&amp;id=48510</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>fix-wml</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D17891">https://phabricator.kde.org/D17891</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>autotests/folding/test.pbl.fold<br /> \
autotests/html/test.pbl.html<br /> autotests/input/test.pbl<br />
autotests/reference/test.pbl.ref<br />
data/syntax/wml.xml</div></div></div><br /><div><strong>To: </strong>nibags, Framework: Syntax \
Highlighting, dhaumann, cullmann<br /><strong>Cc: </strong>kwrite-devel, kde-frameworks-devel, hase, \
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]