[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Fixing KTextEditor Autobraces
From:       Milian Wolff <mail () milianw ! de>
Date:       2018-04-17 19:23:54
Message-ID: 169335849.t7396ZyzG0 () agathebauer
[Download RAW message or body]


On Dienstag, 17. April 2018 18:08:58 CEST Sven Brauch wrote:
> Hi,
> 
> thank you very much for looking into this, I agree the behaviour is
> problematic.
> 
> Can you please create a diff using git and post it on
> phabricator.kde.org? Sharing changed copies of source files does not scale.
> 
> There, you can also comment on your own changes inline in the code,
> which will make it much easier to follow your explanations.
> 
> There are some methods which are called to move the cursor left/right.
> You could clear the stack there. You could also connect to the
> cursorPositionChanged() signal. But let's do further discussion on
> Phabricator :)

Also, do write unit tests. This documents your behavior, and makes sure it 
actually works. And it also verifies it will not be broken easily in the 
future.

-- 
Milian Wolff
mail@milianw.de
http://milianw.de
["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]