[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 128971: Add cross compile support for katehighlightingindex.
From: Ralf Habacker <ralf.habacker () freenet ! de>
Date: 2018-03-25 12:46:43
Message-ID: 20180325124643.20698.81416 () mimi ! kde ! org
[Download RAW message or body]
--===============8612619011436672357==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 13, 2016, 12:20 p.m., Christoph Cullmann wrote:
> > Hi, this code will be removed from master:
> >
> > https://git.reviewboard.kde.org/r/129384/
> >
> > The same patch needs to be done for syntax-highlighting framework I guess.
> > For install: the indexer shall not be installed at all.
With commit cda999c901a9b38439f1d3ffc4c4fc3ae717061c katehighlightingindexer has been \
removed from ktexteditor git repo, which makes this review obsolate. An equivalent \
patch has been reviewed at https://phabricator.kde.org/D7102.
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128971/#review100811
-----------------------------------------------------------
On Sept. 21, 2016, 1:11 p.m., Ralf Habacker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128971/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2016, 1:11 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> Add cross compile support for katehighlightingindex.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 6fadb57ddc667ac0008120910fbaa4994462fa1b
>
>
> Diff: https://git.reviewboard.kde.org/r/128971/diff/1/
>
>
> Testing
> -------
>
> compiled at https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/ktexteditor
>
>
> Thanks,
>
> Ralf Habacker
>
>
--===============8612619011436672357==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128971/">https://git.reviewboard.kde.org/r/128971/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 13th, 2016, 12:20 p.m. CET, \
<strong>Christoph Cullmann</strong> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, this code will be \
removed from master:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: \
inherit;">https://git.reviewboard.kde.org/r/129384/</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
same patch needs to be done for syntax-highlighting framework I guess. For install: \
the indexer shall not be installed at all.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With \
commit cda999c901a9b38439f1d3ffc4c4fc3ae717061c katehighlightingindexer has been \
removed from ktexteditor git repo, which makes this review obsolate. An equivalent \
patch has been reviewed at https://phabricator.kde.org/D7102.</p></pre> <br />
<p>- Ralf</p>
<br />
<p>On September 21st, 2016, 1:11 p.m. CEST, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><em>Updated Sept. 21, 2016, 1:11 p.m.</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add cross compile support for katehighlightingindex.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiled at \
https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/ktexteditor</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: \
grey">(6fadb57ddc667ac0008120910fbaa4994462fa1b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128971/diff/1/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8612619011436672357==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic