--===============7068647517359065753== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 1, 2017, 11:58 a.m., Simon St James wrote: > > Ship It! Whoops - not sure what happened there! If the tests pass, then please go ahead and commit. Thanks for investigating! - Simon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130168/#review103388 ----------------------------------------------------------- On July 1, 2017, 11:50 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130168/ > ----------------------------------------------------------- > > (Updated July 1, 2017, 11:50 a.m.) > > > Review request for Kate and Simon St James. > > > Bugs: 376504 > https://bugs.kde.org/show_bug.cgi?id=376504 > > > Repository: ktexteditor > > > Description > ------- > > With Qt 5.9 (at least), QCoreApplication::hasPendingEvents() (which is already marked as obsolete) seems to unconditionally return true, at least here. The looping didn't make sense at all anyways. > > > Diffs > ----- > > src/vimode/emulatedcommandbar/emulatedcommandbar.cpp 063a7eee > > Diff: https://git.reviewboard.kde.org/r/130168/diff/ > > > Testing > ------- > > Everything works just fine, and the CPU usage doesn't spike. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============7068647517359065753== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130168/ |
On July 1st, 2017, 11:58 a.m. UTC, Simon St James wrote:
Ship It!
Whoops - not sure what happened there! If the tests pass, then please go ahead and commit. Thanks for investigating!
- Simon
On July 1st, 2017, 11:50 a.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:
Review request for Kate and Simon St James.
By Martin Tobias Holmedahl Sandsmark.
Updated July 1, 2017, 11:50 a.m.
Bugs:
376504
Repository:
ktexteditor
Description
Testing
Diffs
|