[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Review Request 130168: Fix CPU usage spiking after showing vi command bar
From:       Martin Tobias Holmedahl Sandsmark <martin.sandsmark () kde ! org>
Date:       2017-07-01 11:50:09
Message-ID: 20170701115009.2970.9013 () mimi ! kde ! org
[Download RAW message or body]

--===============7125619403612025138==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130168/
-----------------------------------------------------------

Review request for Kate and Simon St James.


Bugs: 376504
    https://bugs.kde.org/show_bug.cgi?id=376504


Repository: ktexteditor


Description
-------

With Qt 5.9 (at least), QCoreApplication::hasPendingEvents() seems to unconditionally \
return true, at least here. The looping didn't make sense at all anyways.


Diffs
-----

  src/vimode/emulatedcommandbar/emulatedcommandbar.cpp 063a7eee 

Diff: https://git.reviewboard.kde.org/r/130168/diff/


Testing
-------

Everything works just fine, and the CPU usage doesn't spike.


Thanks,

Martin Tobias Holmedahl Sandsmark


--===============7125619403612025138==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/130168/">https://git.reviewboard.kde.org/r/130168/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate and Simon St James.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>








<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=376504">376504</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With Qt 5.9 (at least), \
QCoreApplication::hasPendingEvents() seems to unconditionally return true, at least \
here. The looping didn't make sense at all anyways.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything works just fine, and the CPU usage doesn't \
spike.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/vimode/emulatedcommandbar/emulatedcommandbar.cpp <span style="color: \
grey">(063a7eee)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/130168/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============7125619403612025138==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic