[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 129948: Also restore "Places" when switching between result-tabs
From: Kåre Särs <kare.sars () iki ! fi>
Date: 2017-02-14 12:56:49
Message-ID: 20170214125649.13662.58054 () mimi ! kde ! org
[Download RAW message or body]
--===============1971067825915308296==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Feb. 14, 2017, 9:45 a.m., Kåre Särs wrote:
> > Woops, didn't you read my last mail? I had already added this.
>
> Alexander Neundorf wrote:
> I missed the PS.
> Thanks.
Sorry, i should have put it in the body of the mail.
- Kåre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129948/#review102529
-----------------------------------------------------------
On Feb. 14, 2017, 12:37 p.m., Alexander Neundorf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129948/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 12:37 p.m.)
>
>
> Review request for Kate and Kåre Särs.
>
>
> Repository: kate
>
>
> Description
> -------
>
> With the patch, now also the "Places" mode is remembered when a search starts, and \
> restored when switching back to the tab, as discussed on the mailing list.
>
> Diffs
> -----
>
> addons/search/plugin_search.h f8f2305
> addons/search/plugin_search.cpp a8a6c3c
>
> Diff: https://git.reviewboard.kde.org/r/129948/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
>
> Thanks,
>
> Alexander Neundorf
>
>
--===============1971067825915308296==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129948/">https://git.reviewboard.kde.org/r/129948/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 14th, 2017, 9:45 a.m. UTC, <b>Kåre \
Särs</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Woops, didn't you read my last mail? I had already added this.</pre> \
</blockquote>
<p>On February 14th, 2017, 12:37 p.m. UTC, <b>Alexander Neundorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
missed the PS. Thanks.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, i should have put \
it in the body of the mail.</pre> <br />
<p>- Kåre</p>
<br />
<p>On February 14th, 2017, 12:37 p.m. UTC, Alexander Neundorf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate and Kåre Särs.</div>
<div>By Alexander Neundorf.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2017, 12:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With the patch, now also the "Places" mode is \
remembered when a search starts, and restored when switching back to the tab, as \
discussed on the mailing list.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested manually.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/search/plugin_search.h <span style="color: grey">(f8f2305)</span></li>
<li>addons/search/plugin_search.cpp <span style="color: grey">(a8a6c3c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129948/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1971067825915308296==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic