From kwrite-devel Mon Jan 23 16:12:11 2017 From: Christoph Cullmann Date: Mon, 23 Jan 2017 16:12:11 +0000 To: kwrite-devel Subject: Re: Review Request 129792: Resolve symbolic links just as KTextEditor Message-Id: <20170123161211.19722.30923 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=148518794032154 --===============3364819156429069031== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129792/#review102216 ----------------------------------------------------------- Ship it! Ship It! - Christoph Cullmann On Jan. 8, 2017, 4:51 p.m., Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129792/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2017, 4:51 p.m.) > > > Review request for Kate, Christoph Cullmann and Dominik Haumann. > > > Bugs: 374564 > http://bugs.kde.org/show_bug.cgi?id=374564 > > > Repository: kate > > > Description > ------- > > KTextEditor::openUrl() resolves any symbolic links but KateDocManager::findDocument() does not. This means that every time you open a symlink Kate believs it is a new file, but you end up with the same url as the previously opened one. > > This patch adds resolving of symlinks also to KateDocManager::findDocument(). > > Another option would be to stop resolving symlinks in KTextEditor, but that is a behaviour change. > > > Diffs > ----- > > kate/katedocmanager.cpp 6bfc0be > > Diff: https://git.reviewboard.kde.org/r/129792/diff/ > > > Testing > ------- > > Opening the same symlink many times does not create multiple document instances of the same file. > > > Thanks, > > Kåre Särs > > --===============3364819156429069031== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129792/

Ship it!

Ship It!

- Christoph Cullmann

On January 8th, 2017, 4:51 p.m. UTC, Kåre Särs wrote:

Review request for Kate, Christoph Cullmann and Dominik Haumann.

By Kåre Särs.

Updated Jan. 8, 2017, 4:51 p.m.

Bugs: 374564

Repository: kate

Description

KTextEditor::openUrl() resolves any symbolic links but KateDocManager::findDocument() does not. This means that every time you open a symlink Kate believs it is a new file, but you end up with the same url as the previously opened one.

This patch adds resolving of symlinks also to KateDocManager::findDocument().

Another option would be to stop resolving symlinks in KTextEditor, but that is a behaviour change.

Testing

Opening the same symlink many times does not create multiple document instances of the same file.

Diffs

kate/katedocmanager.cpp (6bfc0be)

View Diff

--===============3364819156429069031==--