[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 129792: Resolve symbolic links just as KTextEditor
From: Kåre Särs <kare.sars () iki ! fi>
Date: 2017-01-23 13:04:32
Message-ID: 20170123130432.19722.19016 () mimi ! kde ! org
[Download RAW message or body]
--===============8094236713565122731==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 8, 2017, 1:52 p.m., Christoph Cullmann wrote:
> > canonicalFilePath() will return empty path if file doesn't exist, I think one \
> > want only to replace the filepath if that doesn't happen.
Did you notice my update?
- Kåre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129792/#review101870
-----------------------------------------------------------
On Jan. 8, 2017, 4:51 p.m., Kåre Särs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129792/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2017, 4:51 p.m.)
>
>
> Review request for Kate, Christoph Cullmann and Dominik Haumann.
>
>
> Bugs: 374564
> http://bugs.kde.org/show_bug.cgi?id=374564
>
>
> Repository: kate
>
>
> Description
> -------
>
> KTextEditor::openUrl() resolves any symbolic links but \
> KateDocManager::findDocument() does not. This means that every time you open a \
> symlink Kate believs it is a new file, but you end up with the same url as the \
> previously opened one.
> This patch adds resolving of symlinks also to KateDocManager::findDocument().
>
> Another option would be to stop resolving symlinks in KTextEditor, but that is a \
> behaviour change.
>
> Diffs
> -----
>
> kate/katedocmanager.cpp 6bfc0be
>
> Diff: https://git.reviewboard.kde.org/r/129792/diff/
>
>
> Testing
> -------
>
> Opening the same symlink many times does not create multiple document instances of \
> the same file.
>
> Thanks,
>
> Kåre Särs
>
>
--===============8094236713565122731==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129792/">https://git.reviewboard.kde.org/r/129792/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 8th, 2017, 1:52 p.m. UTC, <b>Christoph \
Cullmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">canonicalFilePath() will return empty path if file \
doesn't exist, I think one want only to replace the filepath if that doesn't \
happen.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you notice my \
update?</pre> <br />
<p>- Kåre</p>
<br />
<p>On January 8th, 2017, 4:51 p.m. UTC, Kåre Särs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate, Christoph Cullmann and Dominik Haumann.</div>
<div>By Kåre Särs.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2017, 4:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=374564">374564</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KTextEditor::openUrl() resolves any symbolic links but \
KateDocManager::findDocument() does not. This means that every time you open a \
symlink Kate believs it is a new file, but you end up with the same url as the \
previously opened one.
This patch adds resolving of symlinks also to KateDocManager::findDocument().
Another option would be to stop resolving symlinks in KTextEditor, but that is a \
behaviour change.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Opening the same symlink many times does not create multiple document \
instances of the same file.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/katedocmanager.cpp <span style="color: grey">(6bfc0be)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129792/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8094236713565122731==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic