[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 128631: Adding Qt5 classes to C++ synatx highlighting
From: Christoph Cullmann <cullmann () kde ! org>
Date: 2017-01-09 5:21:14
Message-ID: 20170109052114.23051.14634 () mimi ! kde ! org
[Download RAW message or body]
--===============8124471604401006182==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 6, 2017, 11:29 a.m., Kevin Funk wrote:
> > src/syntax/data/cpp.xml, line 1566
> > <https://git.reviewboard.kde.org/r/128631/diff/1/?file=473756#file473756line1566>
> >
> > Looking at that again. Do we really, really need to add all classes to the syntax \
> > highlighting file?
> > Did anyone ever measure the performance impact of this?
> >
> > IMO that's the job of KDevelop to auto-complete... If you want to have proper \
> > auto-completion, use KDevelop.
> > Highlighting Qt macros & Qt global functions (starting with a 'q') are still fine \
> > though. There are way less items for those.
>
> Friedrich W. H. Kossebau wrote:
> If all Qt classes, also from all the non-core Qt modules, are added to this \
> non-ISO-C++ syntax file, would it not be consequent to also add all KDE Frameworks \
> classes & macros as well? That is something I would expect from a data file being \
> part of KDE Frameworks itself. Not only for promotional reasons. If the answer is \
> no, the reasoning for that should perhaps be applied to deciding what Qt classes to \
> include here as well.
> Dominik Haumann wrote:
> KDE classes are only useful for KDE developers - and let's face it: that is us, and \
> essentially pretty much no one else.
> Qt is by far more widely used, so we indeed can argue that is is useful. As \
> mentioned already in another post, I still am against adding /both/ Qt4 and Qt5 \
> classes, especially since Qt5 is mostly Qt4 compatible.
> With respect to performance: We could add a unit test in the syntax-highlighting \
> framework, then you will know for sure.
> But besides that, given the keyword list is a binary search, I think this is fast, \
> even when we have 200 or so more items in the list.
My opinion would be:
1) Its a Hash for the keywords, I doubt it makes a measurable diff to have there some \
more or some less ones. 2) I would kill Qt4 and only keep Qt5, Qt4 is more or less \
dead for "new" things 3) Qt is one of the only toolkits around for C++, I think it \
makes sense to have per default highlighting for it.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128631/#review101833
-----------------------------------------------------------
On Aug. 8, 2016, 7:26 p.m., Thomas Fischer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128631/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2016, 7:26 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> Adding Qt5 classes and a non-class (`QStringLiteral`) to C++ syntax highlighting
>
>
> Diffs
> -----
>
> src/syntax/data/cpp.xml c3a5cbe
>
> Diff: https://git.reviewboard.kde.org/r/128631/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Fischer
>
>
--===============8124471604401006182==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128631/">https://git.reviewboard.kde.org/r/128631/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 6th, 2017, 11:29 a.m. UTC, <b>Kevin \
Funk</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128631/diff/1/?file=473756#file473756line1566" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/syntax/data/cpp.xml</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1566</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nt"><list</span> <span class="na">name=</span><span \
class="s">"Qt5Classes"</span><span class="nt">></span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Looking at that again. Do we really, really need to add all classes to the \
syntax highlighting file?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Did anyone ever measure the performance \
impact of this?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">IMO that's the job of KDevelop to \
auto-complete... If you want to have proper auto-completion, use KDevelop.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Highlighting Qt macros & Qt global functions (starting with a 'q') are \
still fine though. There are way less items for those.</p></pre> </blockquote>
<p>On January 6th, 2017, 1:31 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
all Qt classes, also from all the non-core Qt modules, are added to this non-ISO-C++ \
syntax file, would it not be consequent to also add all KDE Frameworks classes & \
macros as well? That is something I would expect from a data file being part of KDE \
Frameworks itself. Not only for promotional reasons. If the answer is no, the \
reasoning for that should perhaps be applied to deciding what Qt classes to include \
here as well.</p></pre> </blockquote>
<p>On January 6th, 2017, 7:08 p.m. UTC, <b>Dominik Haumann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDE \
classes are only useful for KDE developers - and let's face it: that is us, and \
essentially pretty much no one else.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Qt is by far more \
widely used, so we indeed can argue that is is useful. As mentioned already in \
another post, I still am against adding /both/ Qt4 and Qt5 classes, especially since \
Qt5 is mostly Qt4 compatible.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">With respect to \
performance: We could add a unit test in the syntax-highlighting framework, then you \
will know for sure.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">But besides that, given the keyword \
list is a binary search, I think this is fast, even when we have 200 or so more items \
in the list.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">My opinion would be:</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">1) Its a Hash for the \
keywords, I doubt it makes a measurable diff to have there some more or some less \
ones. 2) I would kill Qt4 and only keep Qt5, Qt4 is more or less dead for "new" \
things 3) Qt is one of the only toolkits around for C++, I think it makes sense to \
have per default highlighting for it.</p></pre> <br />
<p>- Christoph</p>
<br />
<p>On August 8th, 2016, 7:26 p.m. UTC, Thomas Fischer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Thomas Fischer.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2016, 7:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Adding Qt5 classes and a non-class (<code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">QStringLiteral</code>) to C++ syntax highlighting</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/syntax/data/cpp.xml <span style="color: grey">(c3a5cbe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128631/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8124471604401006182==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic