--===============4394985803806924131== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129758/#review101772 ----------------------------------------------------------- Ship it! Even with test, ship it ;=) - Christoph Cullmann On Jan. 3, 2017, 11:35 a.m., Dominik Haumann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129758/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2017, 11:35 a.m.) > > > Review request for Kate and Christoph Cullmann. > > > Bugs: 374163 > https://bugs.kde.org/show_bug.cgi?id=374163 > > > Repository: ktexteditor > > > Description > ------- > > Drag and drop of selected text in forward direction sets wrong selection and cursor afterwards, see bug #374163. > This patch fixes this. > > > Diffs > ----- > > autotests/src/kateview_test.h 672e74e > autotests/src/kateview_test.cpp 950184f > src/view/kateviewinternal.cpp d2fff0a > > Diff: https://git.reviewboard.kde.org/r/129758/diff/ > > > Testing > ------- > > Added unit test (a bit ugly due to bugs in QTest: drag and drop blocks, so a singleShot timer as workaround is added). > > > Thanks, > > Dominik Haumann > > --===============4394985803806924131== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129758/ |
Ship it!
Even with test, ship it ;=)
- Christoph Cullmann
On January 3rd, 2017, 11:35 a.m. UTC, Dominik Haumann wrote:
Review request for Kate and Christoph Cullmann.
By Dominik Haumann.
Updated Jan. 3, 2017, 11:35 a.m.
Bugs:
374163
Repository:
ktexteditor
Description
Testing
Diffs
|