'Review Request 129758: Fix: When dragging a text in forward direction a selection is "dragged" by a '

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Review Request 129758: Fix: When dragging a text in forward direction a selection is "dragged" by a 
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2017-01-03 11:35:08
Message-ID: 20170103113508.31377.308 () mimi ! kde ! org
[Download RAW message or body]

--===============8405862968529542492==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129758/
-----------------------------------------------------------

Review request for Kate and Christoph Cullmann.


Bugs: 374163
    https://bugs.kde.org/show_bug.cgi?id=374163


Repository: ktexteditor


Description
-------

Drag and drop of selected text in forward direction sets wrong selection and cursor \
afterwards, see bug #374163. This patch fixes this.


Diffs
-----

  autotests/src/kateview_test.h 672e74e 
  autotests/src/kateview_test.cpp 950184f 
  src/view/kateviewinternal.cpp d2fff0a 

Diff: https://git.reviewboard.kde.org/r/129758/diff/


Testing
-------

Added unit test (a bit ugly due to bugs in QTest: drag and drop blocks, so a \
singleShot timer as workaround is added).


Thanks,

Dominik Haumann


--===============8405862968529542492==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129758/">https://git.reviewboard.kde.org/r/129758/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Dominik Haumann.</div>








<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=374163">374163</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Drag and drop of selected text in forward direction \
sets wrong selection and cursor afterwards, see bug #374163. This patch fixes \
this.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added unit test (a bit ugly due to bugs in QTest: drag \
and drop blocks, so a singleShot timer as workaround is added).</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/src/kateview_test.h <span style="color: grey">(672e74e)</span></li>

 <li>autotests/src/kateview_test.cpp <span style="color: grey">(950184f)</span></li>

 <li>src/view/kateviewinternal.cpp <span style="color: grey">(d2fff0a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129758/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============8405862968529542492==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic