[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 128971: Add cross compile support for katehighlightingindex.
From:       Aleix Pol Gonzalez <aleixpol () kde ! org>
Date:       2016-10-17 10:34:48
Message-ID: 20161017103448.31521.55013 () mimi ! kde ! org
[Download RAW message or body]

--===============1670402512433294784==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit



> On Sept. 21, 2016, 2:19 p.m., Aleix Pol Gonzalez wrote:
> > src/CMakeLists.txt, line 227
> > <https://git.reviewboard.kde.org/r/128971/diff/1/?file=477243#file477243line227>
> > 
> > Why's that `KATEHIGHLIGHTINGINDEXER_EXECUTABLE`?
> > 
> > I'd say we should have a separate Config.cmake file for that one, so it can be \
> > found. See other frameworks (e.g. KCoreAddons) on how to do that.
> 
> Ralf Habacker wrote:
> Because the main review at https://git.reviewboard.kde.org/r/129025/ got a +0 I \
> assume to have a +0 here too. If no please provide a spec how to do. I tried it out \
> without success and ask for help but did not get any answer for about 8 month. 
> Anthony Fieroni wrote:
> So, Ralf, i think it's not needed to check any cross compilation presence if \
> KF5_HOST_TOOLING is not defined, if it is then use it w/o else branch i.e. \
> if(CMAKE_CROSSCOMPILING AND KF5_HOST_TOOLING) find_file(TARGETSFILE \
> KF5TextEditor/KF5TextEditorToolingTargets.cmake PATHS ${KF5_HOST_TOOLING} \
> ${CMAKE_CURRENT_LIST_DIR} NO_DEFAULT_PATH) include("${TARGETSFILE}")
> endif()
> And KF5TextEditorToolingTargets.cmake must be specified.
> 
> Ralf Habacker wrote:
> You can give me an example how to setup this file named \
> KF5TextEditorToolingTargets.cmake 
> Ralf Habacker wrote:
> @Anthony: this does not work - recent build system of ktexteditor is not designed \
> to let katehighlightingindexer target be overriden in this way. 
> Aleix Pol Gonzalez wrote:
> The idea behind ToolingTargets is:
> 1. You export the tooling targets (i.e. executables) into a separate Targets.cmake \
> file. 2. When it's imported from other projects, you either include the one from \
> the target platform or if cross compiling you include the host's platform 
> HTH
> 
> Ralf Habacker wrote:
> Sure, I know that, please provide an example.
> 
> Aleix Pol Gonzalez wrote:
> I've been looking into this and it's certainly a special case because the tool is \
> not being installed, hence exporting the target won't help much. In fact, to \
> cross-compile this piece of code one needs to have a build directory in place of \
> the project. I'd say it's barely acceptable. 
> Solutions I propose:
> 
> - we export the tool
> - we use external project to compile the tool, this time with the host's tooling \
>                 https://cmake.org/cmake/help/v3.0/module/ExternalProject.html
> - we port the tool into a scripting language
> - we use your patch and hope other people trying to cross-compile this piece of \
> code will figure it out. 
> Hope this helps, sorry for being picky on this.
> 
> Ralf Habacker wrote:
> Implementing topic 2 would require to setup and maintain a complete cross compile \
> inside ktexteditor (which is huge) and need to be replicated into every additional \
> kf5 package requiring non installed native tools. Usable and maintainted remote and \
> locale cross compile environments like obs are already there with near zero costs \
> except being familiar with administering and build setup. I guess jenkins would \
> also be able to do this, but it needs someone to set up and maintain.    
> Porting the tool mentioned in topic 3 for example to python has the disadvantage to \
> add the python interpreter as an additional dependency. The currently supported \
> cross plattform script language would be cmake, which requires someone to implement \
> and to maintain the tool. 
> The appended patch addresses topic 1 and 4 of your list and is complete to enable \
> cross build ktexteditor for windows using the obs or any other external \
> infrastructure.  
> I understand your last sentence that I' granted to apply this patch to the repo, if \
> not please let me know. 
> Nicolás Alvarez wrote:
> Wait for the 'Ship It!' on Reviewboard (that's what it's for) ;)
> 
> Aleix Pol Gonzalez wrote:
> I don't really have much else to say. This is going to work to some extent. I think \
> it can be done in other ways, but then it's more a matter of what the maintainers \
> consider best and how important cross-compilation is for them, IMHO. 
> +0 from me, let Kate maintainers decide whether they want this.
> 
> Ralf Habacker wrote:
> Sorry, must be a misunderstanding. You provided 4 choices, this patch implements \
> two of them - what is left over to be blocked ? 
> Aleix Pol Gonzalez wrote:
> The tool is not being exported. Exporting a tool means installing them and exposing \
> it for other modules to use, which could be pointless because this tool is not \
> meant to be used elsewhere. 
> Ralf Habacker wrote:
> What about installing it only on request say adding -DINSTALL_INTERNAL_TOOLS=1 on \
> cmake configure line ? 
> Aleix Pol Gonzalez wrote:
> The more I think about it, the more convinced I am that the cleanest approach is \
> just to make sure the host tooling is used when compiling `katehighlightingindex` \
> and anything else is a hack. 
> Ralf Habacker wrote:
> I don't see any 'host tooling' support in ktexteditor repo. Also I cannot find any \
> information in the internet relating to 'KDE host tooling' or 'host tooling'. Can \
> you specific this term ?

Hi, I pushed an example that does something like I had in mind, maybe you like the \
approach: kde:scratch/apol/toolingasexternalproject-test


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128971/#review99354
-----------------------------------------------------------


On Sept. 21, 2016, 1:11 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128971/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 1:11 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Add cross compile support for katehighlightingindex.
> 
> 
> Diffs
> -----
> 
> src/CMakeLists.txt 6fadb57ddc667ac0008120910fbaa4994462fa1b 
> 
> Diff: https://git.reviewboard.kde.org/r/128971/diff/
> 
> 
> Testing
> -------
> 
> compiled at https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/ktexteditor
>  
> 
> Thanks,
> 
> Ralf Habacker
> 
> 


--===============1670402512433294784==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128971/">https://git.reviewboard.kde.org/r/128971/</a>
  </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On September 21st, 2016, 2:19 p.m. CEST, <b>Aleix \
Pol Gonzalez</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  


<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/128971/diff/1/?file=477243#file477243line227" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/CMakeLists.txt</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">227</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">if(CMAKE_CROSSCOMPILING AND KATEHIGHLIGHTINGINDEXER_EXECUTABLE)</pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why's \
that <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: \
inherit;">KATEHIGHLIGHTINGINDEXER_EXECUTABLE</code>?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd \
say we should have a separate Config.cmake file for that one, so it can be found. See \
other frameworks (e.g. KCoreAddons) on how to do that.</p></pre>  </blockquote>



 <p>On September 27th, 2016, 8:31 a.m. CEST, <b>Ralf Habacker</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Because the main review at https://git.reviewboard.kde.org/r/129025/ got a \
+0 I assume to have a +0 here too. If no please provide a spec how to do. I tried it \
out without success and ask for help but did not get any answer for about 8 \
month.</p></pre>  </blockquote>





 <p>On September 27th, 2016, 8:53 a.m. CEST, <b>Anthony Fieroni</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, \
Ralf, i think it's not needed to check any cross compilation presence if \
KF5_HOST_TOOLING is not defined, if it is then use it w/o else branch i.e. \
if(CMAKE_CROSSCOMPILING AND KF5_HOST_TOOLING)  find_file(TARGETSFILE \
KF5TextEditor/KF5TextEditorToolingTargets.cmake PATHS ${KF5_HOST_TOOLING} \
${CMAKE_CURRENT_LIST_DIR} NO_DEFAULT_PATH)  include("${TARGETSFILE}")
endif()
And KF5TextEditorToolingTargets.cmake must be specified.</p></pre>
 </blockquote>





 <p>On September 27th, 2016, 9:02 a.m. CEST, <b>Ralf Habacker</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
can give me an example how to setup this file named \
KF5TextEditorToolingTargets.cmake</p></pre>  </blockquote>





 <p>On September 27th, 2016, 9:06 a.m. CEST, <b>Ralf Habacker</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">@Anthony: this does not work - recent build system of ktexteditor is not \
designed to let katehighlightingindexer target be overriden in this way.</p></pre>  \
</blockquote>





 <p>On September 27th, 2016, 2:57 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
idea behind ToolingTargets is: 1. You export the tooling targets (i.e. executables) \
into a separate Targets.cmake file. 2. When it's imported from other projects, you \
either include the one from the target platform or if cross compiling you include the \
host's platform</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">HTH</p></pre>  </blockquote>





 <p>On September 27th, 2016, 3:02 p.m. CEST, <b>Ralf Habacker</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sure, \
I know that, please provide an example.</p></pre>  </blockquote>





 <p>On September 28th, 2016, 4:32 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've \
been looking into this and it's certainly a special case because the tool is not \
being installed, hence exporting the target won't help much. In fact, to \
cross-compile this piece of code one needs to have a build directory in place of the \
project. I'd say it's barely acceptable.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Solutions I \
propose:</p> <ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">we export the tool</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">we use external project to compile the tool, this time \
with the host's tooling \
https://cmake.org/cmake/help/v3.0/module/ExternalProject.html</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">we port the tool into a scripting language</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">we use \
your patch and hope other people trying to cross-compile this piece of code will \
figure it out.</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hope this helps, sorry for being picky on \
this.</p></pre>  </blockquote>





 <p>On October 13th, 2016, 11:48 a.m. CEST, <b>Ralf Habacker</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Implementing topic 2 would require to setup and maintain a complete cross \
compile inside ktexteditor (which is huge) and need to be replicated into every \
additional kf5 package requiring non installed native tools. Usable and maintainted \
remote and locale cross compile environments like obs are already there with near \
zero costs except being familiar with administering and build setup. I guess jenkins \
would also be able to do this, but it needs someone to set up and maintain.   </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Porting the tool mentioned in topic 3 for example to python has the \
disadvantage to add the python interpreter as an additional dependency. The currently \
supported cross plattform script language would be cmake, which requires someone to \
implement and to maintain the tool.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The appended patch \
addresses topic 1 and 4 of your list and is complete to enable cross build \
ktexteditor for windows using the obs or any other external infrastructure. </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I understand your last sentence that I' granted to apply this patch to the \
repo, if not please let me know.</p></pre>  </blockquote>





 <p>On October 13th, 2016, 9:57 p.m. CEST, <b>Nicolás Alvarez</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wait \
for the 'Ship It!' on Reviewboard (that's what it's for) ;)</p></pre>  </blockquote>





 <p>On October 14th, 2016, 3:01 a.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't really have much else to say. This is going to work to some extent. I think it \
can be done in other ways, but then it's more a matter of what the maintainers \
consider best and how important cross-compilation is for them, IMHO.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">+0 from me, let Kate maintainers decide whether they want this.</p></pre>  \
</blockquote>





 <p>On October 17th, 2016, 9:29 a.m. CEST, <b>Ralf Habacker</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Sorry, must be a misunderstanding. You provided 4 choices, this patch \
implements two of them - what is left over to be blocked ?</p></pre>  </blockquote>





 <p>On October 17th, 2016, 9:57 a.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
tool is not being exported. Exporting a tool means installing them and exposing it \
for other modules to use, which could be pointless because this tool is not meant to \
be used elsewhere.</p></pre>  </blockquote>





 <p>On October 17th, 2016, 11:39 a.m. CEST, <b>Ralf Habacker</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What \
about installing it only on request say adding -DINSTALL_INTERNAL_TOOLS=1 on cmake \
configure line ?</p></pre>  </blockquote>





 <p>On October 17th, 2016, 11:43 a.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
more I think about it, the more convinced I am that the cleanest approach is just to \
make sure the host tooling is used when compiling <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">katehighlightingindex</code> and anything else is a hack.</p></pre>  \
</blockquote>





 <p>On October 17th, 2016, 11:50 a.m. CEST, <b>Ralf Habacker</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't see any 'host tooling' support in ktexteditor repo. Also I cannot find any \
information in the internet relating to 'KDE host tooling' or 'host tooling'. Can you \
specific this term ?</p></pre>  </blockquote>







</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Hi, I pushed an example that does something like I had in mind, maybe you \
like the approach: kde:scratch/apol/toolingasexternalproject-test</p></pre> <br />




<p>- Aleix</p>


<br />
<p>On September 21st, 2016, 1:11 p.m. CEST, Ralf Habacker wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Ralf Habacker.</div>


<p style="color: grey;"><i>Updated Sept. 21, 2016, 1:11 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add cross compile support for katehighlightingindex.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiled at \
https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/ktexteditor</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: \
grey">(6fadb57ddc667ac0008120910fbaa4994462fa1b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128971/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============1670402512433294784==--


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic