[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 128905: Add syntax highlighting support for Praat
From:       Volker Krause <vkrause () kde ! org>
Date:       2016-09-27 16:52:09
Message-ID: 4703233.zIP0m3KHTp () vkpc5
[Download RAW message or body]


On Monday 19 September 2016 00:27:34 José Joaquín Atria wrote:
> Sure. We could use the file I use for testing the Rouge lexer, which I also
> wrote.
> 
> You can see it here:
> https://raw.githubusercontent.com/jneen/rouge/master/spec/visual/samples/pra
> at

This is perfect, thanks!

> That's a fairly complete visual test set. If you were thinking of a smaller
> representative one, it could e the language demo, also from Rouge:
> https://raw.githubusercontent.com/jneen/rouge/master/lib/rouge/demos/praat
> 
> How should I add it? And how do those unit tests work? Should I also add
> some reference that says how they should be highlighted?

I'll take care of this as we sync the new XML files to the kde:syntax-
highlighting repo, the reference data will be generated to match Kate's 
output.

(We are currently in the process of factoring out the highlighting engine and 
syntax data of KTextEditor into KF5::SyntaxHighlighting, the tests are in the 
new repo)

Regards,
Volker

> On Sun, Sep 18, 2016 at 1:40 PM, Volker Krause <vkrause@kde.org> wrote:
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/128905/
> > 
> > Could you provide a Praat file we can use for automated regression
> > testing? Thanks!
> > 
> > 
> > - Volker Krause
> > 
> > On September 14th, 2016, 11:27 a.m. UTC, José Joaquín Atria wrote:
> > Review request for Kate.
> > By José Joaquín Atria.
> > 
> > *Updated Sept. 14, 2016, 11:27 a.m.*
> > *Repository: * ktexteditor
> > Description
> > 
> > Praat (praat.org) is an acoustic analysis software extensively used in
> > Phonetics research. This commit adds syntax highlighting for its internal
> > scripting language.
> > 
> > Testing
> > 
> > $ ./validatehl.sh praat.xml
> > praat.xml validates
> > 
> > Diffs
> > 
> >    - src/syntax/data/praat.xml (PRE-CREATION)
> > 
> > View Diff <https://git.reviewboard.kde.org/r/128905/diff/>

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]