[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 128971: Add cross compile support for katehighlightingindex.
From: Ralf Habacker <ralf.habacker () freenet ! de>
Date: 2016-09-27 6:31:19
Message-ID: 20160927063119.14576.20457 () mimi ! kde ! org
[Download RAW message or body]
--===============3450746657841371642==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 21, 2016, 2:19 nachm., Aleix Pol Gonzalez wrote:
> > src/CMakeLists.txt, line 227
> > <https://git.reviewboard.kde.org/r/128971/diff/1/?file=477243#file477243line227>
> >
> > Why's that `KATEHIGHLIGHTINGINDEXER_EXECUTABLE`?
> >
> > I'd say we should have a separate Config.cmake file for that one, so it can be \
> > found. See other frameworks (e.g. KCoreAddons) on how to do that.
Because the main review at https://git.reviewboard.kde.org/r/129025/ got a +0 I \
assume to have a +0 here too. If no please provide a spec how to do. I tried it out \
without success and ask for help but did not get any answer for about 8 month.
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128971/#review99354
-----------------------------------------------------------
On Sept. 21, 2016, 1:11 nachm., Ralf Habacker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128971/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2016, 1:11 nachm.)
>
>
> Review request for Kate.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> Add cross compile support for katehighlightingindex.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 6fadb57ddc667ac0008120910fbaa4994462fa1b
>
> Diff: https://git.reviewboard.kde.org/r/128971/diff/
>
>
> Testing
> -------
>
> compiled at https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/ktexteditor
>
>
> Thanks,
>
> Ralf Habacker
>
>
--===============3450746657841371642==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128971/">https://git.reviewboard.kde.org/r/128971/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 21st, 2016, 2:19 nachm. CEST, \
<b>Aleix Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128971/diff/1/?file=477243#file477243line227" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">227</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">if(CMAKE_CROSSCOMPILING AND KATEHIGHLIGHTINGINDEXER_EXECUTABLE)</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why's \
that <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: \
inherit;">KATEHIGHLIGHTINGINDEXER_EXECUTABLE</code>?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd \
say we should have a separate Config.cmake file for that one, so it can be found. See \
other frameworks (e.g. KCoreAddons) on how to do that.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Because the main review at https://git.reviewboard.kde.org/r/129025/ got a \
+0 I assume to have a +0 here too. If no please provide a spec how to do. I tried it \
out without success and ask for help but did not get any answer for about 8 \
month.</p></pre> <br />
<p>- Ralf</p>
<br />
<p>On September 21st, 2016, 1:11 nachm. CEST, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2016, 1:11 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add cross compile support for katehighlightingindex.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiled at \
https://build.opensuse.org/package/show/home:rhabacker:branches:KDE:Frameworks526/ktexteditor</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: \
grey">(6fadb57ddc667ac0008120910fbaa4994462fa1b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128971/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3450746657841371642==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic