[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 128905: Add syntax highlighting support for Praat
From: Christoph Cullmann <cullmann () kde ! org>
Date: 2016-09-22 15:07:36
Message-ID: 20160922150736.26270.48404 () mimi ! kde ! org
[Download RAW message or body]
--===============5127301915009231548==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Sept. 22, 2016, 10:19 a.m., Sven Brauch wrote:
> > Eh, sorry, I forgot to submit this a few days ago. Now I think we \
> > should wait until Oct 1st, otherwise we break the 2-week (e.g. string) \
> > freeze for KDE Frameworks 5.27. But no worries, it's not forgotten, \
> > I'll add it for 5.28 a month later. :)
>
> José Joaquín Atria wrote:
> No problem. Thanks!
>
> Milian Wolff wrote:
> Sven, since when are highlight files translated?
>
> Burkhard Lück wrote:
> syntax/data/*.xml has 347 hits in \
> l10n-kf5/templates/messages/frameworks/ktexteditor5.pot
> Nicolás Alvarez wrote:
> Highlighter names are extracted as translatable strings, and some of them \
> are translated (eg. "Apache Configuration" appears as "Configuración de \
> Apache" in Spanish). But plain language names like "Praat" would just be \
> copied verbatim by translators, so practically speaking I don't think \
> submitting this would be a problem for the string freeze.
> Milian Wolff wrote:
> Interesting, thanks for the clarification.
>
> Sven Brauch wrote:
> I was already shouted at once for submitting a highlighter during string \
> freeze, so not doing that again unless there's a general policy that we \
> can do that ;)
I think waiting 2 weeks won't kill a kitten ;=)
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128905/#review99409
-----------------------------------------------------------
On Sept. 14, 2016, 11:27 a.m., José Joaquín Atria wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128905/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2016, 11:27 a.m.)
>
>
> Review request for Kate.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> Praat (praat.org) is an acoustic analysis software extensively used in \
> Phonetics research. This commit adds syntax highlighting for its internal \
> scripting language.
>
> Diffs
> -----
>
> src/syntax/data/praat.xml PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/128905/diff/
>
>
> Testing
> -------
>
> $ ./validatehl.sh praat.xml
> praat.xml validates
>
>
> Thanks,
>
> José Joaquín Atria
>
>
--===============5127301915009231548==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128905/">https://git.reviewboard.kde.org/r/128905/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On September 22nd, 2016, \
10:19 a.m. UTC, <b>Sven Brauch</b> wrote:</p> <blockquote \
style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Eh, sorry, I forgot to submit \
this a few days ago. Now I think we should wait until Oct 1st, otherwise we \
break the 2-week (e.g. string) freeze for KDE Frameworks 5.27. But no \
worries, it's not forgotten, I'll add it for 5.28 a month later. \
:)</p></pre> </blockquote>
<p>On September 22nd, 2016, 10:40 a.m. UTC, <b>José Joaquín Atria</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">No problem. \
Thanks!</p></pre> </blockquote>
<p>On September 22nd, 2016, 1:14 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Sven, since when are \
highlight files translated?</p></pre> </blockquote>
<p>On September 22nd, 2016, 1:46 p.m. UTC, <b>Burkhard Lück</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">syntax/data/*.xml has 347 hits in \
l10n-kf5/templates/messages/frameworks/ktexteditor5.pot</pre> \
</blockquote>
<p>On September 22nd, 2016, 2:17 p.m. UTC, <b>Nicolás Alvarez</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Highlighter \
names are extracted as translatable strings, and some of them are \
translated (eg. "Apache Configuration" appears as "Configuración de \
Apache" in Spanish). But plain language names like "Praat" would just be \
copied verbatim by translators, so practically speaking I don't think \
submitting this would be a problem for the string freeze.</p></pre> \
</blockquote>
<p>On September 22nd, 2016, 2:34 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Interesting, thanks for the \
clarification.</p></pre> </blockquote>
<p>On September 22nd, 2016, 2:54 p.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I was already shouted at once \
for submitting a highlighter during string freeze, so not doing that again \
unless there's a general policy that we can do that ;)</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think waiting 2 weeks won't kill a kitten \
;=)</p></pre> <br />
<p>- Christoph</p>
<br />
<p>On September 14th, 2016, 11:27 a.m. UTC, José Joaquín Atria wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By José Joaquín Atria.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2016, 11:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Praat (praat.org) is an \
acoustic analysis software extensively used in Phonetics research. This \
commit adds syntax highlighting for its internal scripting \
language.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">$ ./validatehl.sh praat.xml \
praat.xml validates</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/syntax/data/praat.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128905/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5127301915009231548==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic