[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 128905: Add syntax highlighting support for Praat
From:       José Joaquín Atria <jjatria () gmail ! com>
Date:       2016-09-17 13:54:15
Message-ID: CA+CQHCJM0FCqv367geK-r6g4eEkE6FKJrpAPuLr+M+FOoZUL8Q () mail ! gmail ! com
[Download RAW message or body]

Nice! Thanks for being so quick about it.

I don't think I can commit to the KDE repositories, since this is my first
contribution.


Jos=C3=A9 Joaqu=C3=ADn Atria

www.pinguinorodriguez.cl

On Fri, Sep 16, 2016 at 9:44 PM, Sven Brauch <mail@svenbrauch.de> wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128905/
>
> Ship it!
>
> Looks fine to me. Thanks! Do you have commit access to the KDE repositori=
es, or do you want me to submit this for you?
>
>
> - Sven Brauch
>
> On September 14th, 2016, 11:27 a.m. UTC, Jos=C3=A9 Joaqu=C3=ADn Atria wro=
te:
> Review request for Kate.
> By Jos=C3=A9 Joaqu=C3=ADn Atria.
>
> *Updated Sept. 14, 2016, 11:27 a.m.*
> *Repository: * ktexteditor
> Description
>
> Praat (praat.org) is an acoustic analysis software extensively used in Ph=
onetics research. This commit adds syntax highlighting for its internal scr=
ipting language.
>
> Testing
>
> $ ./validatehl.sh praat.xml
> praat.xml validates
>
> Diffs
>
>    - src/syntax/data/praat.xml (PRE-CREATION)
>
> View Diff <https://git.reviewboard.kde.org/r/128905/diff/>
>

[Attachment #3 (text/html)]

<div dir="ltr"><div>Nice! Thanks for being so quick about it.<br><br></div>I \
don&#39;t think I can commit to the KDE repositories, since this is my first \
contribution.<br><br></div><div class="gmail_extra"><br clear="all"><div><div \
class="gmail_signature" data-smartmail="gmail_signature">José Joaquín \
Atria<br><br><a href="http://www.pinguinorodriguez.cl" \
target="_blank">www.pinguinorodriguez.cl</a></div></div> <br><div \
class="gmail_quote">On Fri, Sep 16, 2016 at 9:44 PM, Sven Brauch <span \
dir="ltr">&lt;<a href="mailto:mail@svenbrauch.de" \
target="_blank">mail@svenbrauch.de</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">



 <div>
  <div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><span class="">
   <table style="border:1px #c9c399 solid;border-radius:6px" cellpadding="12" \
bgcolor="#f9f3c9" width="100%">  <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128905/" \
target="_blank">https://git.reviewboard.kde.<wbr>org/r/128905/</a>  </td>
    </tr>
   </tbody></table>
   <br>



</span><p>

Ship it!

</p>



 <pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p \
style="padding:0;margin:0;line-height:inherit;white-space:inherit">Looks fine to me. \
Thanks! Do you have commit access to the KDE repositories, or do you want me to \
submit this for you?</p></pre>  <br>









<p>- Sven Brauch</p><span class="">


<br>
<p>On September 14th, 2016, 11:27 a.m. UTC, José Joaquín Atria wrote:</p>








</span><table style="border:1px #888a85 solid;border-radius:6px" cellpadding="12" \
cellspacing="0" bgcolor="#fefadf" width="100%">  <tbody><tr>
  <td><span class="">

<div>Review request for Kate.</div>
<div>By José Joaquín Atria.</div>


</span><p style="color:grey"><i>Updated Sept. 14, 2016, 11:27 a.m.</i></p><span \
class="">









<div style="margin-top:1.5em">
 <b style="color:#575012;font-size:10pt">Repository: </b>
ktexteditor
</div>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
 <table style="border:1px solid #b8b5a0" cellpadding="10" cellspacing="0" \
bgcolor="#ffffff" width="100%">  <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p \
style="padding:0;margin:0;line-height:inherit;white-space:inherit">Praat (<a \
href="http://praat.org" target="_blank">praat.org</a>) is an acoustic analysis \
software extensively used in Phonetics research. This commit adds syntax highlighting \
for its internal scripting language.</p></pre>  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" cellpadding="10" cellspacing="0" \
bgcolor="#ffffff" width="100%">  <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p \
style="padding:0;margin:0;line-height:inherit;white-space:inherit">$ ./validatehl.sh \
praat.xml  praat.xml validates</p></pre>
  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">

 <li>src/syntax/data/praat.xml <span style="color:grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128905/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>






  </span></td>
 </tr>
</tbody></table>







  </div>
 </div>


</blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]