[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 128859: Fix regression in KateNormalInputMode
From: Christoph Cullmann <cullmann () kde ! org>
Date: 2016-09-08 10:19:16
Message-ID: 20160908101916.5566.27375 () mimi ! kde ! org
[Download RAW message or body]
--===============3802789029189822787==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128859/#review98996
-----------------------------------------------------------
Ship it!
Hi,
it should work now, but can you keep the enum untouched? The old name indicated: if \
you have no bar, you get the normal one, else you keep the mode, now what happens if \
no bar is there is unclear from the enum name. Fix that, than commit it, thanks!
- Christoph Cullmann
On Sept. 8, 2016, 7:44 a.m., Roman Gilg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128859/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2016, 7:44 a.m.)
>
>
> Review request for Kate and Christoph Cullmann.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> Patch https://quickgit.kde.org/?p=ktexteditor.git&a=commit&h=9223ac51c9453017c9b11718eed858050697cfbd \
> doesn't work 100% correctly:
> Replicating this regression:
> 1. Open search bar in incremental or power mode and if you want to, type in a \
> search pattern 2. Close the search bar, select some other word and open it again in \
> the same mode (!) => search pattern is not set to new word
> You can also:
> 1. like above
> 2. With open search bar select other word in the document and open again in the \
> same mode => search pattern is not set to new word
> In summary: KateNormalInputMode always has to rerun the respective enter methods of \
> KateSearchBar in order to set a newly selected word as the new search pattern.
>
> Diffs
> -----
>
> src/inputmode/katenormalinputmode.h 96d3ca7
> src/inputmode/katenormalinputmode.cpp 71f228d
>
> Diff: https://git.reviewboard.kde.org/r/128859/diff/
>
>
> Testing
> -------
>
> With this fix it's working again the same way as before the regression.
>
>
> Thanks,
>
> Roman Gilg
>
>
--===============3802789029189822787==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128859/">https://git.reviewboard.kde.org/r/128859/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, \
it should work now, but can you keep the enum untouched? The old name indicated: if \
you have no bar, you get the normal one, else you keep the mode, now what happens if \
no bar is there is unclear from the enum name. Fix that, than commit it, \
thanks!</p></pre> <br />
<p>- Christoph Cullmann</p>
<br />
<p>On September 8th, 2016, 7:44 a.m. UTC, Roman Gilg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Roman Gilg.</div>
<p style="color: grey;"><i>Updated Sept. 8, 2016, 7:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Patch \
https://quickgit.kde.org/?p=ktexteditor.git&a=commit&h=9223ac51c9453017c9b11718eed858050697cfbd \
doesn't work 100% correctly:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Replicating this regression: 1. Open \
search bar in incremental or power mode and if you want to, type in a search pattern \
2. Close the search bar, select some other word and open it again in the same mode \
(!) => search pattern is not set to new word</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
can also: 1. like above
2. With open search bar select other word in the document and open again in the same \
mode => search pattern is not set to new word</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
summary: KateNormalInputMode always has to rerun the respective enter methods of \
KateSearchBar in order to set a newly selected word as the new search \
pattern.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With this fix it's working again the same way as \
before the regression.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/inputmode/katenormalinputmode.h <span style="color: \
grey">(96d3ca7)</span></li>
<li>src/inputmode/katenormalinputmode.cpp <span style="color: \
grey">(71f228d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128859/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3802789029189822787==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic