[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 128631: Adding Qt5 classes to C++ synatx highlighting
From: Milian Wolff <mail () milianw ! de>
Date: 2016-08-09 9:20:40
Message-ID: 20160809092040.9365.58977 () mimi ! kde ! org
[Download RAW message or body]
--===============3051316078161317912==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 9, 2016, 5:51 a.m., Kåre Särs wrote:
> > This is a welcome update to me :)
> >
> > Including all classes from http://doc.qt.io/qt-5/classes.html means that we have \
> > a bunch of duplicates with Qt4... will that impact on performance?
> > Could you also add Q_ENUM and other new macros?
>
> Dominik Haumann wrote:
> I wonder I whether we should remove the Qt4 classes in favour of only Qt classes. \
> Qt5 is mostly backwards compatible with Qt4 in terms of classes and functions, so I \
> dont see the point in having all the duplicates. Qt4 is dead, we should remove \
> it...
I'm with Dominik - remove Qt 4, it's EOL.
- Milian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128631/#review98212
-----------------------------------------------------------
On Aug. 8, 2016, 7:26 p.m., Thomas Fischer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128631/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2016, 7:26 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> Adding Qt5 classes and a non-class (`QStringLiteral`) to C++ syntax highlighting
>
>
> Diffs
> -----
>
> src/syntax/data/cpp.xml c3a5cbe
>
> Diff: https://git.reviewboard.kde.org/r/128631/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Fischer
>
>
--===============3051316078161317912==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128631/">https://git.reviewboard.kde.org/r/128631/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 9th, 2016, 5:51 a.m. UTC, <b>Kåre \
Särs</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a welcome update to me :)
Including all classes from http://doc.qt.io/qt-5/classes.html means that we have a \
bunch of duplicates with Qt4... will that impact on performance?
Could you also add Q_ENUM and other new macros?</pre>
</blockquote>
<p>On August 9th, 2016, 6:49 a.m. UTC, <b>Dominik Haumann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
wonder I whether we should remove the Qt4 classes in favour of only Qt classes. Qt5 \
is mostly backwards compatible with Qt4 in terms of classes and functions, so I dont \
see the point in having all the duplicates. Qt4 is dead, we should remove \
it...</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
with Dominik - remove Qt 4, it's EOL.</p></pre> <br />
<p>- Milian</p>
<br />
<p>On August 8th, 2016, 7:26 p.m. UTC, Thomas Fischer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Thomas Fischer.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2016, 7:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Adding Qt5 classes and a non-class (<code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">QStringLiteral</code>) to C++ syntax highlighting</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/syntax/data/cpp.xml <span style="color: grey">(c3a5cbe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128631/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3051316078161317912==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic