[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 128356: Add Text to Search and Next buttons in the search plugin
From: Kåre Särs <kare.sars () iki ! fi>
Date: 2016-07-08 18:01:12
Message-ID: 20160708180112.2360.36255 () mimi ! kde ! org
[Download RAW message or body]
--===============8064851762115778011==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128356/
-----------------------------------------------------------
(Updated July 8, 2016, 6:01 p.m.)
Status
------
This change has been marked as submitted.
Review request for Kate.
Changes
-------
Submitted with commit e7774e46ffe4d04531d1de27b62125a60c625157 by Kåre Särs to \
branch master.
Repository: kate
Description
-------
I have struggled with the search UI changes done at Randa and find that Search needs \
a bigger button. This patch adds text to both 'Search' and 'Next' and also moves the \
'Use this folder' button up to the always visible part. (The tab navigation is also \
improved)
The alternative screen-shots are a little bit more compact but the balance is not as \
good.
Diffs
-----
addons/search/plugin_search.cpp edd6062
addons/search/search.ui 811c413
Diff: https://git.reviewboard.kde.org/r/128356/diff/
Testing
-------
Tried different UIs
File Attachments
----------------
Search & Next with text
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/04/6d1d7d6a-587b-4fa6-bf2e-d194b0f97a5d__SearchUI-Next-with-text.png
Next without text
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/04/9283033a-eef7-4ab1-bcfa-914dc1c35d78__SearchUI-Next-no-text.png
A second more compact option
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/04/c9d1b3c2-9d60-443c-9c0f-6a5171bffc9e__SearchUI-Compact.png
Thanks,
Kåre Särs
--===============8064851762115778011==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128356/">https://git.reviewboard.kde.org/r/128356/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Kåre Särs.</div>
<p style="color: grey;"><i>Updated July 8, 2016, 6:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit e7774e46ffe4d04531d1de27b62125a60c625157 by Kåre \
Särs to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have struggled with the search UI changes done at Randa and find that \
Search needs a bigger button. This patch adds text to both 'Search' and \
'Next' and also moves the 'Use this folder' button up to the always \
visible part. (The tab navigation is also improved)
The alternative screen-shots are a little bit more compact but the balance is not as \
good.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tried different UIs</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/search/plugin_search.cpp <span style="color: grey">(edd6062)</span></li>
<li>addons/search/search.ui <span style="color: grey">(811c413)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128356/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/04/6d1d7d6a-587b-4fa6-bf2e-d194b0f97a5d__SearchUI-Next-with-text.png">Search \
& Next with text</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/04/9283033a-eef7-4ab1-bcfa-914dc1c35d78__SearchUI-Next-no-text.png">Next \
without text</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/04/c9d1b3c2-9d60-443c-9c0f-6a5171bffc9e__SearchUI-Compact.png">A \
second more compact option</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8064851762115778011==--
[Attachment #3 (text/plain)]
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic