'Re: Folding-Preview RFC'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Folding-Preview RFC
From:       "Elv1313 ." <elv1313 () gmail ! com>
Date:       2016-06-22 19:49:26
Message-ID: CAFnK6VU7tMri0C6XqPTWH1UtHPPSms3ynspp8_QSpXG5Z1rSYg () mail ! gmail ! com
[Download RAW message or body]

Here is a cheap muckup for my idea:
http://i.imgur.com/DhYXDWh.png

1) I did dim the document view by 20% so the preview popup more
2) I added the overlay on the right side
3) I unfold and show some > on the side of the folded area (and also
dim it, but I am not sure about that one, maybe it should dim what's
visible and highlight whats folded)
4) I add another vertical line to separate the code from the preview area.

I think this make sense for displaying the folding. It probably
doesn't for the regular scrollbar preview because that would mess the
Y axis offset. I think, however, that the scrollbar preview should
make it obvious that there is folding. What do you think?

Best regards,
Emmanuel

On 22 June 2016 at 02:58, Dominik Haumann <dhaumann@kde.org> wrote:
> Hi,
>
> that is how it is right now:
> If the fold hides 5 lines, then the preview is 5 lines in height.
> If it hides 500 lines, then the preview is as high as possible, etc.
>
> What you are proposing, as I understand, is to simply temporarily
> unfold the fold, on mouse over, right?
>
> That would also be an option, maybe we could paint an overlay to
> darken the upper and lower part that is not part of the fold, so it
> gets clear what's new?
>
> @Christoph: moving the preview to another position could also be a
> solution. I'd need to try that out, though, to get a feeling for that.
>
> Greetings,
> Dominik
>
>
> On Tue, Jun 21, 2016 at 9:15 PM, Elv1313 . <elv1313@gmail.com> wrote:
>> Hi,
>>
>> To give my opinion (purely based on the blog gifs), I think this
>> feature would be more useful to me if it used the full height of then
>> document view rather than a 5 line popup. From my point of view, the
>> most useful aspect of this new feature is being able to "get to a
>> line" faster. 5 lines is useful for this, but having a full overview
>> of the "end result" (aka, the full document), is even more useful.
>> Secondly, an alternate use case is to be able to view code not
>> currently visible in the document view. Of course, this is of limited
>> usefulness, as the preview (rightfully so) crop the lines. However, as
>> both of these use case would benefit from full height preview, I think
>> it make more sense than a popup.
>>
>> So I would propose using ~20% of the right side of the view for a full
>> height (document view height) preview. Doing so as an overlay rather
>> than a popup and without changing the document view (for example, no
>> changes to automatic wrapping). Given that many projects favor shorter
>> line anyway (80 or 120 chars long soft limit), the right side of the
>> view is often underused anyway.
>>
>> On 21 June 2016 at 14:15, Christoph Cullmann <cullmann@absint.com> wrote:
>>> Hi,
>>>
>>> would it make more sense to show the folding preview like the scroll preview
>>> on the right side of the view in 80% instead 1:1 over the text on the left?
>>>
>>> I tried that a bit locally (not 100% correct, just as hack) and IMHO this
>>> is much nicer to use as it not just hides away all content of the view for the quick peek
>>> inside the folding region.
>>>
>>> The current preview is more like unfolding (and back refolding afterwards).
>>>
>>> Greetings
>>> Christoph
>>>
>>> --
>>> ----------------------------- Dr.-Ing. Christoph Cullmann ---------
>>> AbsInt Angewandte Informatik GmbH      Email: cullmann@AbsInt.com
>>> Science Park 1                         Tel:   +49-681-38360-22
>>> 66123 Saarbrücken                      Fax:   +49-681-38360-20
>>> GERMANY                                WWW:   http://www.AbsInt.com
>>> --------------------------------------------------------------------
>>> Geschäftsführung: Dr.-Ing. Christian Ferdinand
>>> Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
>>> _______________________________________________
>>> KWrite-Devel mailing list
>>> KWrite-Devel@kde.org
>>> https://mail.kde.org/mailman/listinfo/kwrite-devel
>> _______________________________________________
>> KWrite-Devel mailing list
>> KWrite-Devel@kde.org
>> https://mail.kde.org/mailman/listinfo/kwrite-devel
> _______________________________________________
> KWrite-Devel mailing list
> KWrite-Devel@kde.org
> https://mail.kde.org/mailman/listinfo/kwrite-devel
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 