[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 128274: kate: revert the name ordering of sessions action menu
From: Michal Humpula <michal.humpula () hudrydum ! cz>
Date: 2016-06-22 17:37:59
Message-ID: 20160622173759.22783.31041 () mimi ! kde ! org
[Download RAW message or body]
--===============5561183028588292367==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128274/
-----------------------------------------------------------
(Updated June 22, 2016, 7:37 p.m.)
Status
------
This change has been marked as submitted.
Review request for Kate and Dominik Haumann.
Changes
-------
Submitted with commit 03c0be31ab04e56be4c831733a4cf44c0248001a by Michal Humpula to branch master.
Repository: kate
Description
-------
Line katesessionsaction.cpp:55 filters only first 10 items from sessions count. Sorting by sessions name \
with 100 sessions makes sessions action useless.
Diffs
-----
kate/session/katesession.h f1fb61a
kate/session/katesession.cpp 5168d28
kate/session/katesessionsaction.cpp 5523003
Diff: https://git.reviewboard.kde.org/r/128274/diff/
Testing
-------
Thanks,
Michal Humpula
--===============5561183028588292367==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128274/">https://git.reviewboard.kde.org/r/128274/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate and Dominik Haumann.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated June 22, 2016, 7:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit \
03c0be31ab04e56be4c831733a4cf44c0248001a by Michal Humpula to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Line katesessionsaction.cpp:55 filters only \
first 10 items from sessions count. Sorting by sessions name with 100 sessions makes sessions action \
useless.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/session/katesession.h <span style="color: grey">(f1fb61a)</span></li>
<li>kate/session/katesession.cpp <span style="color: grey">(5168d28)</span></li>
<li>kate/session/katesessionsaction.cpp <span style="color: grey">(5523003)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128274/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5561183028588292367==--
[Attachment #3 (text/plain)]
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic