'Re: Review Request 128274: kate: revert the name ordering of sessions action menu'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 128274: kate: revert the name ordering of sessions action menu
From:       Christoph Cullmann <cullmann () kde ! org>
Date:       2016-06-22 13:08:50
Message-ID: 20160622130850.22783.22234 () mimi ! kde ! org
[Download RAW message or body]

--===============1775842665579346145==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On June 22, 2016, 1:04 p.m., Christoph Cullmann wrote:
> > Ok, true :/
> > Guess we did overlook that.
> > And I think sorting the lastest 10 used by name ist strange, too.
> 
> Michal Humpula wrote:
> Maybe add some human time information when the session was last used to the \
> sessions menu? Something like "Kate (yesterday)", "ktexteditor (10 days ago)"?

Might make sense, yes.

- Christoph

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128274/#review96796
-----------------------------------------------------------

On June 22, 2016, 1:02 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128274/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 1:02 p.m.)
> 
> 
> Review request for Kate and Dominik Haumann.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> Line katesessionsaction.cpp:55 filters only first 10 items from sessions count. \
> Sorting by sessions name with 100 sessions makes sessions action useless. 
> 
> Diffs
> -----
> 
> kate/session/katesession.h f1fb61a 
> kate/session/katesession.cpp 5168d28 
> kate/session/katesessionsaction.cpp 5523003 
> 
> Diff: https://git.reviewboard.kde.org/r/128274/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
> 

--===============1775842665579346145==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128274/">https://git.reviewboard.kde.org/r/128274/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On June 22nd, 2016, 1:04 p.m. UTC, <b>Christoph \
Cullmann</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ok, true :/ Guess we did overlook that.
And I think sorting the lastest 10 used by name ist strange, too.</p></pre>
 </blockquote>

 <p>On June 22nd, 2016, 1:08 p.m. UTC, <b>Michal Humpula</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe \
add some human time information when the session was last used to the sessions menu? \
Something like "Kate (yesterday)", "ktexteditor (10 days ago)"?</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Might \
make sense, yes.</p></pre> <br />

<p>- Christoph</p>

<br />
<p>On June 22nd, 2016, 1:02 p.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate and Dominik Haumann.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated June 22, 2016, 1:02 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Line katesessionsaction.cpp:55 filters only first 10 \
items from sessions count. Sorting by sessions name with 100 sessions makes sessions \
action useless.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/session/katesession.h <span style="color: grey">(f1fb61a)</span></li>

 <li>kate/session/katesession.cpp <span style="color: grey">(5168d28)</span></li>

 <li>kate/session/katesessionsaction.cpp <span style="color: \
grey">(5523003)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128274/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1775842665579346145==--

[Attachment #3 (text/plain)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 