'Re: Review Request 128218: Add compile option to use QtSingleApplication in stead of DBus for openin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 128218: Add compile option to use QtSingleApplication in stead of DBus for openin
From:       Kåre Särs <kare.sars () iki ! fi>
Date:       2016-06-17 7:31:22
Message-ID: 20160617073122.9803.61516 () mimi ! kde ! org
[Download RAW message or body]

--===============2285015557199338042==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128218/
-----------------------------------------------------------

(Updated June 17, 2016, 7:31 a.m.)

Status
------

This change has been marked as submitted.

Review request for Kate, Christoph Cullmann and Kevin Funk.

Repository: kate

Description
-------

Summary says it all :)

Diffs
-----

  kate/CMakeLists.txt c98ae3c 
  kate/kateapp.h e27c3cb 
  kate/kateapp.cpp 43a8390 
  kate/main.cpp 5b65c1e 
  kate/qtsingleapplication/qtlocalpeer.h PRE-CREATION 
  kate/qtsingleapplication/qtlocalpeer.cpp PRE-CREATION 
  kate/qtsingleapplication/qtlockedfile.h PRE-CREATION 
  kate/qtsingleapplication/qtlockedfile.cpp PRE-CREATION 
  kate/qtsingleapplication/qtlockedfile_unix.cpp PRE-CREATION 
  kate/qtsingleapplication/qtlockedfile_win.cpp PRE-CREATION 
  kate/qtsingleapplication/qtsingleapplication.h PRE-CREATION 
  kate/qtsingleapplication/qtsingleapplication.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128218/diff/

Testing
-------

Compiles on Windows with the option and on Linux without the option set.

Thanks,

Kåre Särs

--===============2285015557199338042==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128218/">https://git.reviewboard.kde.org/r/128218/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate, Christoph Cullmann and Kevin Funk.</div>
<div>By Kåre Särs.</div>

<p style="color: grey;"><i>Updated June 17, 2016, 7:31 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Summary says it all :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles on Windows with the option and on Linux without the option \
set.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/CMakeLists.txt <span style="color: grey">(c98ae3c)</span></li>

 <li>kate/kateapp.h <span style="color: grey">(e27c3cb)</span></li>

 <li>kate/kateapp.cpp <span style="color: grey">(43a8390)</span></li>

 <li>kate/main.cpp <span style="color: grey">(5b65c1e)</span></li>

 <li>kate/qtsingleapplication/qtlocalpeer.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kate/qtsingleapplication/qtlocalpeer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kate/qtsingleapplication/qtlockedfile.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kate/qtsingleapplication/qtlockedfile.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kate/qtsingleapplication/qtlockedfile_unix.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kate/qtsingleapplication/qtlockedfile_win.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kate/qtsingleapplication/qtsingleapplication.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kate/qtsingleapplication/qtsingleapplication.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128218/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2285015557199338042==--

[Attachment #3 (text/plain)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 