'Re: Review Request 127045: Add tests for #235862'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 127045: Add tests for #235862
From:       Michal Humpula <michal.humpula () hudrydum ! cz>
Date:       2016-02-11 18:12:55
Message-ID: 20160211181255.7653.19324 () mimi ! kde ! org
[Download RAW message or body]

--===============5759533137287611467==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127045/#review92267
-----------------------------------------------------------

Ship it!

I would put extra "canary" text line after the testing blok, but this will do too.

- Michal Humpula

On Feb. 11, 2016, 6:05 p.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127045/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 6:05 p.m.)
> 
> 
> Review request for Kate and Christoph Cullmann.
> 
> 
> Bugs: 235862
> https://bugs.kde.org/show_bug.cgi?id=235862
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> This bug was fixed a few years ago, but it is still not closed. Add tests to make sure it is fixed and \
> close it. 
> 
> Diffs
> -----
> 
> autotests/src/vimode/modes.cpp 75bed31 
> 
> Diff: https://git.reviewboard.kde.org/r/127045/diff/
> 
> 
> Testing
> -------
> 
> Build and run tests - all passed.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
> 

--===============5759533137287611467==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127045/">https://git.reviewboard.kde.org/r/127045/</a>
     </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I would put extra "canary" text line after the testing blok, but this will \
do too.</p></pre>  <br />

<p>- Michal Humpula</p>

<br />
<p>On February 11th, 2016, 6:05 p.m. UTC, Boris Egorov wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Boris Egorov.</div>

<p style="color: grey;"><i>Updated Feb. 11, 2016, 6:05 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=235862">235862</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This bug was fixed a few years ago, but it \
is still not closed. Add tests to make sure it is fixed and close it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Build and run tests - all passed.</p></pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/src/vimode/modes.cpp <span style="color: grey">(75bed31)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127045/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5759533137287611467==--

[Attachment #3 (text/plain)]

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 