[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: KTextEditor::SearchInterface
From:       Andreas Cord-Landwehr <cordlandwehr () kde ! org>
Date:       2015-03-28 8:06:44
Message-ID: 1785946.lyZK9iUlba () weatherwax
[Download RAW message or body]

On Friday 20 March 2015 18:36:14 Andreas Cord-Landwehr wrote:
> On Sunday 01 March 2015 10:42:36 Sven Brauch wrote:
> > On 01/03/15 10:33, Andreas Cord-Landwehr wrote:
> > > It's at [1] at line 790ff.
> > 
> > It looks like you could simply replace it by a QString::indexOf call,
> > maybe?
> Hi, after some further code digging I found a couple of other places [1]
> where the search interface is used (using options RegEx, CaseInsensitive,
> or Backwards). From my current point of view (and an IRC discussion with
> Sven), working around the missing search-interface is possible by simply
> using indexOf, QRegExp and adding all the boilderplate code to work with
> Range and Curser elements from KTextEditor.
> 
> However, for me it looks like re-implementing something that is already
> there for Kate, and IMO it seems much more straight forward to simply allow
> a (minimalistic) search interface for KTextEditor.
> 
> I got Sven to be "undecided" about it, other opinions? :)
> 
> Cheers,
> Andreas
> 
> [1]
> http://quickgit.kde.org/?p=kile.git&a=blob&h=cb4e610f0064791585836137d92b3dd
> 8dbfde45a&hb=c4883fa50f2666b503bb846e5a2e1a48b0f2cf5b&f=src%2Feditorextensio
> n.cpp

Good morning, before this is going to be stalled completely, I was told to ask 
specifically for Dominik's and Christoph's opinions.
If you have some, I offer a thankful pint at next Akademy ;)

Cheers,
Andreas
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread]