'Re: Review Request 122504: quickopen: only use bold font for open files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 122504: quickopen: only use bold font for open files
From:       "Alexander Neundorf" <neundorf () kde ! org>
Date:       2015-02-15 21:12:49
Message-ID: 20150215211249.4989.98564 () probe ! kde ! org
[Download RAW message or body]

--===============6405823923019621894==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122504/
-----------------------------------------------------------

(Updated Feb. 15, 2015, 9:12 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate and Christoph Cullmann.

Repository: kate

Description
-------

Without the patch, all files listed by quickopen are using bold font, both the open \
files as well as the files added by the project plugin, and which have not yet been \
opened. At least for me, this makes the list hard to read.
With the patch, bold font is used only for the files which are open, project files \
which have not yet been opened are now using normal font. To me, this makes it easier \
to read and the visible separation of open files, sorted lru, and project files also \
helps scanning visually the open files.

Diffs
-----

  kate/src/katequickopen.cpp b0edd3d 

Diff: https://git.reviewboard.kde.org/r/122504/diff/

Testing
-------

Works for me.

Thanks,

Alexander Neundorf

--===============6405823923019621894==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122504/">https://git.reviewboard.kde.org/r/122504/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Alexander Neundorf.</div>

<p style="color: grey;"><i>Updated Feb. 15, 2015, 9:12 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Without the patch, all files listed by quickopen are \
using bold font, both the open files as well as the files added by the project \
plugin, and which have not yet been opened. At least for me, this makes the list hard \
to read. With the patch, bold font is used only for the files which are open, project \
files which have not yet been opened are now using normal font. To me, this makes it \
easier to read and the visible separation of open files, sorted lru, and project \
files also helps scanning visually the open files.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works for me.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/src/katequickopen.cpp <span style="color: grey">(b0edd3d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122504/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6405823923019621894==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 