'Re: Review Request 122434: Project plugin: only reload if the project file has been modified'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 122434: Project plugin: only reload if the project file has been modified
From:       "Alexander Neundorf" <neundorf () kde ! org>
Date:       2015-02-09 21:13:31
Message-ID: 20150209211331.30354.56827 () probe ! kde ! org
[Download RAW message or body]

--===============3748636092169178951==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122434/
-----------------------------------------------------------

(Updated Feb. 9, 2015, 9:13 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate, Christoph Cullmann and Dominik Haumann.

Repository: kate

Description
-------

Only reload the project if the project file has been modified.
Without this patch the project is reloaded whenever the directory which contains the \
project file is updated. If the proejct file is out-of-source, as is the case for \
cmake-generated kate project files, during "make install" of the project cmake writes \
a install_manifest.txt line by line, one for every file. So for each installed file \
kate reloads the project once, which can take a few minutes at 100% CPU if the \
project installs hundreds of files.

Diffs
-----

  addons/project/kateprojectplugin.cpp 6e56e96 
  addons/project/kateproject.h 3973d0c 
  addons/project/kateproject.cpp 400789e 

Diff: https://git.reviewboard.kde.org/r/122434/diff/

Testing
-------

Tested with cmake as loaded project. During make install of cmake no noticable delay \
happens anymore in kate, before it took maybe 2 minutes at 100% before kate responded \
again.

Thanks,

Alexander Neundorf

--===============3748636092169178951==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122434/">https://git.reviewboard.kde.org/r/122434/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate, Christoph Cullmann and Dominik Haumann.</div>
<div>By Alexander Neundorf.</div>

<p style="color: grey;"><i>Updated Feb. 9, 2015, 9:13 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Only reload the project if the project file has been \
modified. Without this patch the project is reloaded whenever the directory which \
contains the project file is updated. If the proejct file is out-of-source, as is the \
case for cmake-generated kate project files, during "make install" of the project \
cmake writes a install_manifest.txt line by line, one for every file. So for each \
installed file kate reloads the project once, which can take a few minutes at 100% \
CPU if the project installs hundreds of files.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with cmake as loaded project. During make \
install of cmake no noticable delay happens anymore in kate, before it took maybe 2 \
minutes at 100% before kate responded again.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>addons/project/kateprojectplugin.cpp <span style="color: \
grey">(6e56e96)</span></li>

 <li>addons/project/kateproject.h <span style="color: grey">(3973d0c)</span></li>

 <li>addons/project/kateproject.cpp <span style="color: grey">(400789e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122434/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3748636092169178951==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 