'Re: Review Request 121959: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 121959: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().
From:       "Elias Probst" <mail () eliasprobst ! eu>
Date:       2015-01-28 8:25:42
Message-ID: 20150128082542.30683.14447 () probe ! kde ! org
[Download RAW message or body]

--===============5154652289071696580==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121959/
-----------------------------------------------------------

(Updated Jan. 28, 2015, 8:25 a.m.)

Status
------

This change has been marked as submitted.

Review request for Kate.

Repository: kate

Description
-------

Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().

Diffs
-----

  addons/sessionapplet/engine/CMakeLists.txt 0dd9194ee7f5c7f668f0122763df9c2d3e1c80bc \

Diff: https://git.reviewboard.kde.org/r/121959/diff/

Testing
-------

Built + installed as expected.
Functionality couldn't be tested because of \
https://bugs.kde.org/show_bug.cgi?id=342670

Thanks,

Elias Probst

--===============5154652289071696580==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121959/">https://git.reviewboard.kde.org/r/121959/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Elias Probst.</div>

<p style="color: grey;"><i>Updated Jan. 28, 2015, 8:25 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Deprecate kservice_desktop_to_json(), use \
kcoreaddons_desktop_to_json().</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built + installed as expected. Functionality couldn't \
be tested because of https://bugs.kde.org/show_bug.cgi?id=342670</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>addons/sessionapplet/engine/CMakeLists.txt <span style="color: \
grey">(0dd9194ee7f5c7f668f0122763df9c2d3e1c80bc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121959/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5154652289071696580==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 