[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 120299: Go to editing Positions
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2014-10-24 15:19:05
Message-ID: 20141024151905.18178.56196 () probe ! kde ! org
[Download RAW message or body]
--===============7281751680346221947==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120299/#review69106
-----------------------------------------------------------
src/document/katedocument.cpp
<https://git.reviewboard.kde.org/r/120299/#comment48311>
The indentation on this line is wrong. Not sure if we care and correct it.
- Christoph Feck
On Oct. 24, 2014, 1:23 p.m., Ashish Bansal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120299/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 1:23 p.m.)
>
>
> Review request for Kate, Sven Brauch and Dominik Haumann.
>
>
> Bugs: 307457
> https://bugs.kde.org/show_bug.cgi?id=307457
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> Bug 307457 - JJ: Need a shortcut to return to the last editting location. Implementation
>
>
> Diffs
> -----
>
> src/view/kateview.h 0dfa226
> src/view/kateview.cpp 472531b
> src/document/katedocument.h cc43d6a
> src/document/katedocument.cpp 82363ed
>
> Diff: https://git.reviewboard.kde.org/r/120299/diff/
>
>
> Testing
> -------
>
> Well this can be implemented in two ways.Suppose we have several lines text and we insert or \
> delete the text twice but from the same line, so when user presses the shortcut key then we \
> will go through from both of the editing positions having same line but different position. \
> But I think if we save only once per line in consecutive editings then it would be good way \
> and I have uploaded this one's code and is working fine. Well It may have certain problems \
> like if there is increase in the line no.s or decrease then it is gonna make the whole stack \
> lines no.s wrong.Although i have solution to this but i was just making sure if I should make \
> changes according to that or not. Thanks to scummos and dhaumann for helping me :)
>
>
> Thanks,
>
> Ashish Bansal
>
>
--===============7281751680346221947==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120299/">https://git.reviewboard.kde.org/r/120299/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120299/diff/13/?file=316722#file316722line311" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/document/katedocument.cpp</a> <span style="font-weight: normal;">
(Diff revision 13)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">311</font></th> \
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">editingPosStack</span><span class="p">.</span><span \
class="n">resize</span><span class="p">(</span><span class="n">cursorPos</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The indentation on this line is \
wrong. Not sure if we care and correct it.</p></pre> </div>
</div>
<br />
<p>- Christoph Feck</p>
<br />
<p>On October 24th, 2014, 1:23 p.m. UTC, Ashish Bansal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate, Sven Brauch and Dominik Haumann.</div>
<div>By Ashish Bansal.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2014, 1:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=307457">307457</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bug 307457 - \
JJ: Need a shortcut to return to the last editting location. Implementation</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well this can \
be implemented in two ways.Suppose we have several lines text and we insert or delete the text \
twice but from the same line, so when user presses the shortcut key then we will go through \
from both of the editing positions having same line but different position. But I think if we \
save only once per line in consecutive editings then it would be good way and I have uploaded \
this one's code and is working fine. Well It may have certain problems like if there is \
increase in the line no.s or decrease then it is gonna make the whole stack lines no.s \
wrong.Although i have solution to this but i was just making sure if I should make changes \
according to that or not.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> Thanks to scummos and dhaumann for helping me :)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/view/kateview.h <span style="color: grey">(0dfa226)</span></li>
<li>src/view/kateview.cpp <span style="color: grey">(472531b)</span></li>
<li>src/document/katedocument.h <span style="color: grey">(cc43d6a)</span></li>
<li>src/document/katedocument.cpp <span style="color: grey">(82363ed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120299/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7281751680346221947==--
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic