'Re: Review Request 117660: vimode: make the S and C commands change the whole line in visual-line mo'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 117660: vimode: make the S and C commands change the whole line in visual-line mo
From:       Miquel_SabatĂŠ_SolĂ  <mikisabate () gmail ! com>
Date:       2014-09-29 19:44:37
Message-ID: 20140929194437.15675.7988 () probe ! kde ! org
[Download RAW message or body]

--===============1240488981303171306==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117660/
-----------------------------------------------------------

(Updated Sept. 29, 2014, 7:44 p.m.)

Status
------

This change has been discarded.

Review request for Kate, Michal Humpula and Simon St James.

Repository: ktexteditor

Description
-------

When in visual-line mode, the C command should behave exactly as the c command in \
this case: change the whole line. This is because the purpose of visual-line mode is \
to perform commands on lines, not in some parts of a line. The current behavior \
doesn't make a lot of sense imho: it deletes the current line and goes to the second \
column of the next line in insert mode. Plus, the behavior of the C command in this \
patch matches the behavior in vim for this case. I know that we don't *have* to mimic \
all the vim behavior, but in this case it makes much more sense than the actual \
behavior in kate.

So, why have I included also the S command in this patch? Well, before this patch the \
S command behaved like the C command in this case in Kate. So, I think we should \
apply the same logic as in the C's case. Vim does something that I don't fully \
understand, so I guess we won't be mimicking vim here :P

Diffs
-----

  autotests/src/vimode/modes.cpp cf4705d 
  src/vimode/katevivisualmode.cpp 25d4bd9 

Diff: https://git.reviewboard.kde.org/r/117660/diff/

Testing
-------

All tests are passing. I've also added a couple of tests.

Thanks,

Miquel SabatĂŠ SolĂ 

--===============1240488981303171306==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117660/">https://git.reviewboard.kde.org/r/117660/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate, Michal Humpula and Simon St James.</div>
<div>By Miquel SabatĂŠ SolĂ .</div>

<p style="color: grey;"><i>Updated Sept. 29, 2014, 7:44 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When in visual-line mode, the C command should behave exactly as the c \
command in this case: change the whole line. This is because the purpose of \
visual-line mode is to perform commands on lines, not in some parts of a line. The \
current behavior doesn&#39;t make a lot of sense imho: it deletes the current line \
and goes to the second column of the next line in insert mode. Plus, the behavior of \
the C command in this patch matches the behavior in vim for this case. I know that we \
don&#39;t *have* to mimic all the vim behavior, but in this case it makes much more \
sense than the actual behavior in kate.

So, why have I included also the S command in this patch? Well, before this patch the \
S command behaved like the C command in this case in Kate. So, I think we should \
apply the same logic as in the C&#39;s case. Vim does something that I don&#39;t \
fully understand, so I guess we won&#39;t be mimicking vim here :P</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All tests are passing. I&#39;ve also added a couple of tests.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/src/vimode/modes.cpp <span style="color: grey">(cf4705d)</span></li>

 <li>src/vimode/katevivisualmode.cpp <span style="color: grey">(25d4bd9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117660/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1240488981303171306==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 