[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 113440: katepart: Add "Smart Tabs" radio button to KateIndentConfigTab
From: "Joseph Wenninger" <kde () jowenn ! at>
Date: 2014-09-21 11:50:22
Message-ID: 20140921115022.6970.30300 () probe ! kde ! org
[Download RAW message or body]
--===============4703000378077074971==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113440/#review67123
-----------------------------------------------------------
What's the difference of the new flag in comparison to the config()->replaceTabsDyn() \
flag?
- Joseph Wenninger
On Okt. 25, 2013, 10:22 nachm., Roman Lapin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113440/
> -----------------------------------------------------------
>
> (Updated Okt. 25, 2013, 10:22 nachm.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> This patch adds simple "Smart Tabs" function to Kate.
>
> If radio button "Smart Tabulators" is checked on Indentation Config Tab, Kate \
> inserts tabs for indentation, but fine alignment to a necessary column is done \
> only via spaces without replacing them with tabs. It helps to preserve alignment \
> (e.g. of comments), when Tab width is changed.
>
> Diffs
> -----
>
> part/dialogs/indentationconfigwidget.ui 6d1fc08
> part/dialogs/katedialogs.cpp 1bfefde
> part/document/katedocument.cpp 42b540d
> part/utils/kateconfig.h be3441d
> part/utils/kateconfig.cpp e5d8b66
>
> Diff: https://git.reviewboard.kde.org/r/113440/diff/
>
>
> Testing
> -------
>
> Kate builds.
> Changing and applying of variations rbIndent* works fine.
> Tested with several values of Tab width and Indentation width.
> PS. This is my first patch, but seems it's work in way what I want (I hope).
>
>
> Thanks,
>
> Roman Lapin
>
>
--===============4703000378077074971==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113440/">https://git.reviewboard.kde.org/r/113440/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">What's the difference of the new flag in comparison to the \
config()->replaceTabsDyn() flag?</p></pre> <br />
<p>- Joseph Wenninger</p>
<br />
<p>On Oktober 25th, 2013, 10:22 nachm. UTC, Roman Lapin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Roman Lapin.</div>
<p style="color: grey;"><i>Updated Okt. 25, 2013, 10:22 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds simple "Smart Tabs" function to Kate.
If radio button "Smart Tabulators" is checked on Indentation Config Tab, \
Kate inserts tabs for indentation, but fine alignment to a necessary column is done \
only via spaces without replacing them with tabs. It helps to preserve alignment \
(e.g. of comments), when Tab width is changed. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Kate builds. Changing and applying of variations rbIndent* works fine.
Tested with several values of Tab width and Indentation width.
PS. This is my first patch, but seems it's work in way what I want (I hope).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/dialogs/indentationconfigwidget.ui <span style="color: \
grey">(6d1fc08)</span></li>
<li>part/dialogs/katedialogs.cpp <span style="color: grey">(1bfefde)</span></li>
<li>part/document/katedocument.cpp <span style="color: grey">(42b540d)</span></li>
<li>part/utils/kateconfig.h <span style="color: grey">(be3441d)</span></li>
<li>part/utils/kateconfig.cpp <span style="color: grey">(e5d8b66)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113440/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4703000378077074971==--
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic