[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 119857: Reworked kate/addons/symbolviewer's bash_parser.cpp
From: "Joseph Wenninger" <kde () jowenn ! at>
Date: 2014-09-07 9:49:17
Message-ID: 20140907094917.8756.71436 () probe ! kde ! org
[Download RAW message or body]
--===============8108551797817740814==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119857/#review65966
-----------------------------------------------------------
I do not see anything about testing. We have some files for testing kate syntax \
highlighting, this is not really highlighting, but I think that location is still \
good, please add a valid bash file there, that did not work correctly in symbol \
viewer, but does work now. Also please show, that the working things still work.
I see this request ist against 4.13 branch, please update the patch to 4.14 branch \
and if it gets a ship it in the next iteration, please also apply it to master (kf5)
- Joseph Wenninger
On Aug. 20, 2014, 1:55 nachm., Dominik Kummer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119857/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2014, 1:55 nachm.)
>
>
> Review request for Kate, Dominik Kummer, Myroslav Zapukhlyak, and Kåre Särs.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Now it is possible to use Function Namespaces like: Argparser::Args.resolve()
> and get /Functions/Argparser/Args/resolve in Symbolviewer.
> Additional Arrays and Variables are listed
>
>
> Diffs
> -----
>
> addons/kate/symbolviewer/bash_parser.cpp 6b76a04
>
> Diff: https://git.reviewboard.kde.org/r/119857/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dominik Kummer
>
>
--===============8108551797817740814==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119857/">https://git.reviewboard.kde.org/r/119857/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do \
not see anything about testing. We have some files for testing kate syntax \
highlighting, this is not really highlighting, but I think that location is still \
good, please add a valid bash file there, that did not work correctly in symbol \
viewer, but does work now. Also please show, that the working things still work.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I see this request ist against 4.13 branch, please \
update the patch to 4.14 branch and if it gets a ship it in the next iteration, \
please also apply it to master (kf5)</p></pre> <br />
<p>- Joseph Wenninger</p>
<br />
<p>On August 20th, 2014, 1:55 nachm. UTC, Dominik Kummer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate, Dominik Kummer, Myroslav Zapukhlyak, and Kåre \
Särs.</div> <div>By Dominik Kummer.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2014, 1:55 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now it is possible to use Function Namespaces like: \
Argparser::Args.resolve()<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> and get \
/Functions/Argparser/Args/resolve in Symbolviewer.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
Additional Arrays and Variables are listed</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/kate/symbolviewer/bash_parser.cpp <span style="color: \
grey">(6b76a04)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119857/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8108551797817740814==--
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic