[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 119715: Fix the build on Windows using MSVC 2013.
From: "Joseph Wenninger" <kde () jowenn ! at>
Date: 2014-08-11 14:04:44
Message-ID: 20140811140444.14668.57810 () probe ! kde ! org
[Download RAW message or body]
--===============0038185290299151420==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119715/#review64265
-----------------------------------------------------------
Please fix the one issue in the session manager, afterwards feel free to commit
kate/src/katemainwindow.cpp
<https://git.reviewboard.kde.org/r/119715/#comment44917>
This removal should be fine
kate/src/katemdi.cpp
<https://git.reviewboard.kde.org/r/119715/#comment44915>
This should be safe, please do it
kate/src/session/katesessionmanager.cpp
<https://git.reviewboard.kde.org/r/119715/#comment44916>
Please don't remove unistd.h, it is needed on linux. Either keep it or wrap it in \
an #infdef Q_OS_WIN
#ifndef Q_OS_WIN
// ensure that the file is written to disk
#ifdef HAVE_FDATASYNC
fdatasync(fileToSync.handle());
#else
fsync(fileToSync.handle());
#endif
#endif
- Joseph Wenninger
On Aug. 11, 2014, 1:30 nachm., Cristian Oneț wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119715/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 1:30 nachm.)
>
>
> Review request for Kate and Joseph Wenninger.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Remove some unused Unix specific headers and replace QStringLiteral
> with QLatin1String because QStringLiteral does not work on all
> platforms when taking a concatenated string as a parameter.
>
>
> Diffs
> -----
>
> kate/src/katemainwindow.cpp 93de89f630accc5cc0c588a0db41e93d00196d92
> kate/src/katemdi.cpp c78eda111e76be232aea5ffbcb44cad3c65b8497
> kate/src/session/katesessionmanager.cpp a1ed5387775296d492332b2299ef1733ea4baf65
>
> Diff: https://git.reviewboard.kde.org/r/119715/diff/
>
>
> Testing
> -------
>
> Built a run kate.
>
>
> Thanks,
>
> Cristian Oneț
>
>
--===============0038185290299151420==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119715/">https://git.reviewboard.kde.org/r/119715/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please fix the one issue in the session manager, afterwards feel free to \
commit</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119715/diff/1/?file=303738#file303738line83" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kate/src/katemainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">83</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
<unistd.h></span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
removal should be fine</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119715/diff/1/?file=303739#file303739line90" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kate/src/katemdi.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ToggleToolViewAction::slotToggled(bool t)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">90</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">static</span> <span class="k">const</span> <span class="n">QString</span> \
<span class="n">guiDescription</span> <span class="o">=</span> <span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">""</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
should be safe, please do it</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119715/diff/1/?file=303740#file303740line46" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kate/src/session/katesessionmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">46</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include \
<unistd.h></span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please don't remove unistd.h, it is needed on linux. Either keep it or wrap \
it in an #infdef Q_OS_WIN</p> <h1 style="font-size: 100%;text-rendering: \
inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">ifndef \
Q_OS_WIN</h1> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%"> <span style="color: #408080; font-style: \
italic">// ensure that the file is written to disk</span> </pre></div>
</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">ifdef HAVE_FDATASYNC</h1> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> \
fdatasync(fileToSync.handle()); </pre></div>
</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">else</h1> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> \
fsync(fileToSync.handle()); </pre></div>
</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">endif</h1> <h1 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">endif</h1></pre> </div>
</div>
<br />
<p>- Joseph Wenninger</p>
<br />
<p>On August 11th, 2014, 1:30 nachm. UTC, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate and Joseph Wenninger.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2014, 1:30 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remove some unused Unix specific headers and replace \
QStringLiteral<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> with QLatin1String because QStringLiteral does not \
work on all<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> platforms when taking a concatenated string as a \
parameter.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built a run kate.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/src/katemainwindow.cpp <span style="color: \
grey">(93de89f630accc5cc0c588a0db41e93d00196d92)</span></li>
<li>kate/src/katemdi.cpp <span style="color: \
grey">(c78eda111e76be232aea5ffbcb44cad3c65b8497)</span></li>
<li>kate/src/session/katesessionmanager.cpp <span style="color: \
grey">(a1ed5387775296d492332b2299ef1733ea4baf65)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119715/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0038185290299151420==--
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic