'Re: Review Request 119695: Replace setenv to more portable qputenv'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 119695: Replace setenv to more portable qputenv
From:       "Joseph Wenninger" <kde () jowenn ! at>
Date:       2014-08-11 9:24:47
Message-ID: 20140811092447.14667.84914 () probe ! kde ! org
[Download RAW message or body]

--===============5507628835853580487==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119695/#review64240
-----------------------------------------------------------

Ship it!

I'vve tried it and I don't see regression on linux. If it helps Windows, please \
commit

- Joseph Wenninger

On Aug. 10, 2014, 5:13 nachm., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119695/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2014, 5:13 nachm.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> setenv is not present on Windows when compiling with MSVC
> 
> 
> Diffs
> -----
> 
> addons/konsole/kateconsole.cpp 235f42a 
> kate/src/kateapp.cpp 960ddbf 
> 
> Diff: https://git.reviewboard.kde.org/r/119695/diff/
> 
> 
> Testing
> -------
> 
> Compiled fine.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
> 

--===============5507628835853580487==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119695/">https://git.reviewboard.kde.org/r/119695/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'vve \
tried it and I don't see regression on linux. If it helps Windows, please \
commit</p></pre>  <br />

<p>- Joseph Wenninger</p>

<br />
<p>On August 10th, 2014, 5:13 nachm. UTC, Dāvis Mosāns wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Dāvis Mosāns.</div>

<p style="color: grey;"><i>Updated Aug. 10, 2014, 5:13 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">setenv is not present on Windows when compiling with \
MSVC</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiled fine.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>addons/konsole/kateconsole.cpp <span style="color: grey">(235f42a)</span></li>

 <li>kate/src/kateapp.cpp <span style="color: grey">(960ddbf)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119695/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5507628835853580487==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 