'Re: Review Request 119507: vimode: simplified the findSurroundingBrackets function.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 119507: vimode: simplified the findSurroundingBrackets function.
From:       Miquel_SabatĂŠ_SolĂ  <mikisabate () gmail ! com>
Date:       2014-07-28 8:40:02
Message-ID: 20140728084002.15443.20444 () probe ! kde ! org
[Download RAW message or body]

--===============6091328393907926915==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119507/
-----------------------------------------------------------

(Updated July 28, 2014, 8:40 a.m.)

Status
------

This change has been marked as submitted.

Review request for Kate and Michal Humpula.

Repository: ktexteditor

Description
-------

Instead of implementing this function with a weird algorithm that uses a QStack, I \
simplified it by using good ol' Catalan numbers \
(http://en.wikipedia.org/wiki/Catalan_number). Less allocations, simpler, etc. :)

Diffs
-----

  src/vimode/modes/modebase.h 56b0db4 
  src/vimode/modes/modebase.cpp fca75cc 
  src/vimode/modes/normalvimode.cpp 2dfa6be 

Diff: https://git.reviewboard.kde.org/r/119507/diff/

Testing
-------

make test

Thanks,

Miquel SabatĂŠ SolĂ 

--===============6091328393907926915==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119507/">https://git.reviewboard.kde.org/r/119507/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate and Michal Humpula.</div>
<div>By Miquel SabatĂŠ SolĂ .</div>

<p style="color: grey;"><i>Updated July 28, 2014, 8:40 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Instead of implementing this function with a weird \
algorithm that uses a QStack, I simplified it by using good ol' Catalan numbers \
(http://en.wikipedia.org/wiki/Catalan_number). Less allocations, simpler, etc. \
:)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make test</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/vimode/modes/modebase.h <span style="color: grey">(56b0db4)</span></li>

 <li>src/vimode/modes/modebase.cpp <span style="color: grey">(fca75cc)</span></li>

 <li>src/vimode/modes/normalvimode.cpp <span style="color: \
grey">(2dfa6be)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119507/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6091328393907926915==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 