'Re: Review Request 116580: RFC: remove highlight of other languages from reST'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 116580: RFC: remove highlight of other languages from reST
From:       "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date:       2014-07-26 13:48:21
Message-ID: 20140726134821.4048.61960 () probe ! kde ! org
[Download RAW message or body]

--===============6690985044220215503==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116580/
-----------------------------------------------------------

(Updated July 26, 2014, 1:48 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate and Alex Turbov.

Repository: kate

Description
-------

Remove the reST HL rules to include syntax highlighting of specific languages for \
code blocks.

I'm rather on the fence about actually merging this, as it can be seen as a \
regression. OTOH it avoids silly things like including C++/Python/Doxygen styles in \
CMake (e.g. see http://commits.kde.org/kate/9695f1785ad8 ).

Diffs
-----

  part/syntax/data/rest.xml 4cd9165ac3af103872e23a34afb7ae543025de2a 
  .gitlog PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116580/diff/

Testing
-------

Thanks,

Matthew Woehlke

--===============6690985044220215503==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116580/">https://git.reviewboard.kde.org/r/116580/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate and Alex Turbov.</div>
<div>By Matthew Woehlke.</div>

<p style="color: grey;"><i>Updated July 26, 2014, 1:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove the reST HL rules to include syntax highlighting of specific \
languages for code blocks.

I&#39;m rather on the fence about actually merging this, as it can be seen as a \
regression. OTOH it avoids silly things like including C++/Python/Doxygen styles in \
CMake (e.g. see http://commits.kde.org/kate/9695f1785ad8 ).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/syntax/data/rest.xml <span style="color: \
grey">(4cd9165ac3af103872e23a34afb7ae543025de2a)</span></li>

 <li>.gitlog <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116580/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6690985044220215503==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 