'Re: Review Request 119389: Replaced all nullptr's for Q_NULLPTR'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 119389: Replaced all nullptr's for Q_NULLPTR
From:       Miquel_SabatĂŠ_SolĂ  <mikisabate () gmail ! com>
Date:       2014-07-21 18:24:04
Message-ID: 20140721182404.14616.75055 () probe ! kde ! org
[Download RAW message or body]

--===============8871532266718694034==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119389/
-----------------------------------------------------------

(Updated July 21, 2014, 6:24 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate.

Repository: ktexteditor

Description
-------

According to this: https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 \
, nullptr is not an available C++11 feature for Frameworks. So, I've just replaced \
all instances of nullptr to Q_NULLPTR.

Diffs
-----

  autotests/src/katedocument_test.cpp 5076dd1 
  autotests/src/kateview_test.cpp d5379f8 
  autotests/src/vimode/base.cpp cc67af6 
  src/completion/katekeywordcompletion.cpp de5121f 
  src/document/katedocument.h b5032d3 
  src/document/katedocument.cpp 95f8a89 
  src/include/ktexteditor/command.h ec32f62 
  src/include/ktexteditor/document.h c2b9990 
  src/inputmode/katenormalinputmodefactory.cpp b8b086b 
  src/utils/application.cpp b6a2921 
  src/utils/document.cpp b42593b 
  src/utils/kateglobal.cpp a162a15 
  src/utils/ktexteditor.cpp 98524d6 
  src/utils/mainwindow.cpp 371b7cc 
  src/view/kateview.h e3b0b43 
  src/view/kateview.cpp 8f405cb 

Diff: https://git.reviewboard.kde.org/r/119389/diff/

Testing
-------

make test

Thanks,

Miquel SabatĂŠ SolĂ 

--===============8871532266718694034==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119389/">https://git.reviewboard.kde.org/r/119389/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Miquel SabatĂŠ SolĂ .</div>

<p style="color: grey;"><i>Updated July 21, 2014, 6:24 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">According to this: \
https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 \
, nullptr is not an available C++11 feature for Frameworks. So, I've just replaced \
all instances of nullptr to Q_NULLPTR.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make test</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/src/katedocument_test.cpp <span style="color: \
grey">(5076dd1)</span></li>

 <li>autotests/src/kateview_test.cpp <span style="color: grey">(d5379f8)</span></li>

 <li>autotests/src/vimode/base.cpp <span style="color: grey">(cc67af6)</span></li>

 <li>src/completion/katekeywordcompletion.cpp <span style="color: \
grey">(de5121f)</span></li>

 <li>src/document/katedocument.h <span style="color: grey">(b5032d3)</span></li>

 <li>src/document/katedocument.cpp <span style="color: grey">(95f8a89)</span></li>

 <li>src/include/ktexteditor/command.h <span style="color: \
grey">(ec32f62)</span></li>

 <li>src/include/ktexteditor/document.h <span style="color: \
grey">(c2b9990)</span></li>

 <li>src/inputmode/katenormalinputmodefactory.cpp <span style="color: \
grey">(b8b086b)</span></li>

 <li>src/utils/application.cpp <span style="color: grey">(b6a2921)</span></li>

 <li>src/utils/document.cpp <span style="color: grey">(b42593b)</span></li>

 <li>src/utils/kateglobal.cpp <span style="color: grey">(a162a15)</span></li>

 <li>src/utils/ktexteditor.cpp <span style="color: grey">(98524d6)</span></li>

 <li>src/utils/mainwindow.cpp <span style="color: grey">(371b7cc)</span></li>

 <li>src/view/kateview.h <span style="color: grey">(e3b0b43)</span></li>

 <li>src/view/kateview.cpp <span style="color: grey">(8f405cb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119389/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8871532266718694034==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 