[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 119182: Remove the additional close button from the default UI
From: "Phil Stefan" <sogatori () gmail ! com>
Date: 2014-07-21 15:31:09
Message-ID: 20140721153109.14617.47343 () probe ! kde ! org
[Download RAW message or body]
--===============5418229663809623604==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 19, 2014, 9:58 p.m., Christoph Cullmann wrote:
> > I am not actually sure if removing a standard UI button is such a good idea.
> > The toolbar is too filled with stuff per default, but perhaps we need some more \
> > general fix for that and think which buttons are needed at all.
Have you read the e-mail, where I have outlined my reasoning? \
http://lists.kde.org/?l=kwrite-devel&m=140482014429676&w=2 I would very much \
apprechiate your input on the point I've made. :)
- Phil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119182/#review62726
-----------------------------------------------------------
On July 8, 2014, 3:32 p.m., Phil Stefan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119182/
> -----------------------------------------------------------
>
> (Updated July 8, 2014, 3:32 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Documents can be now be closed via the close button in each individual tab. This \
> patch removes the close button from the default UI, as it duplicates functionality. \
>
> Diffs
> -----
>
> kate/data/kateui.rc bbb637b
>
> Diff: https://git.reviewboard.kde.org/r/119182/diff/
>
>
> Testing
> -------
>
> Recompiled on my computer and it was indeed gone! Other than that, there's not \
> difference here.
>
> Thanks,
>
> Phil Stefan
>
>
--===============5418229663809623604==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119182/">https://git.reviewboard.kde.org/r/119182/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 19th, 2014, 9:58 p.m. UTC, <b>Christoph \
Cullmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I am not actually sure if removing a standard UI \
button is such a good idea.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> The toolbar is too filled with stuff \
per default, but perhaps we need some more general fix for that and think which \
buttons are needed at all.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have \
you read the e-mail, where I have outlined my reasoning? \
http://lists.kde.org/?l=kwrite-devel&m=140482014429676&w=2 I would very much \
apprechiate your input on the point I've made. :)</p></pre> <br />
<p>- Phil</p>
<br />
<p>On July 8th, 2014, 3:32 p.m. UTC, Phil Stefan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Phil Stefan.</div>
<p style="color: grey;"><i>Updated July 8, 2014, 3:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Documents can be now be closed via the close button in \
each individual tab. This patch removes the close button from the default UI, as it \
duplicates functionality.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Recompiled on my computer and it was indeed gone! \
Other than that, there's not difference here.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/data/kateui.rc <span style="color: grey">(bbb637b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119182/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5418229663809623604==--
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic