'Re: Review Request 119376: Implemented the "viewsInSameSplitView" method from the KTextEditor::MainW'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 119376: Implemented the "viewsInSameSplitView" method from the KTextEditor::MainW
From:       Miquel_SabatĂŠ_SolĂ  <mikisabate () gmail ! com>
Date:       2014-07-20 20:30:11
Message-ID: 20140720203011.14616.79410 () probe ! kde ! org
[Download RAW message or body]

--===============4562657184813615562==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119376/
-----------------------------------------------------------

(Updated July 20, 2014, 8:30 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate.

Repository: kate

Description
-------

Review #119210 added the "viewsInSameSplitView" method to the KTE::MainWindow class. \
In this patch I'm implementing this method for Kate.

Diffs
-----

  kate/src/katemainwindow.h b40a568 
  kate/src/kateviewmanager.h 796adfa 
  kate/src/kateviewmanager.cpp c91c08f 

Diff: https://git.reviewboard.kde.org/r/119376/diff/

Testing
-------

To test this I've used an implementation of the "only" command in ktexteditor (I'll \
submit that patch to reviewboard once this patch gets accepted ;) ).

Thanks,

Miquel SabatĂŠ SolĂ 

--===============4562657184813615562==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119376/">https://git.reviewboard.kde.org/r/119376/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Miquel SabatĂŠ SolĂ .</div>

<p style="color: grey;"><i>Updated July 20, 2014, 8:30 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Review #119210 added the "viewsInSameSplitView" method \
to the KTE::MainWindow class. In this patch I'm implementing this method for \
Kate.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">To test this I've used an implementation of the "only" \
command in ktexteditor (I'll submit that patch to reviewboard once this patch gets \
accepted ;) ).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/src/katemainwindow.h <span style="color: grey">(b40a568)</span></li>

 <li>kate/src/kateviewmanager.h <span style="color: grey">(796adfa)</span></li>

 <li>kate/src/kateviewmanager.cpp <span style="color: grey">(c91c08f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119376/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4562657184813615562==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 