'Re: Review Request 118616: Add action to reload syntax highlighting files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 118616: Add action to reload syntax highlighting files
From:       Christoph Rüßler <christoph.ruessler () mailbox ! org>
Date:       2014-07-20 15:04:33
Message-ID: 20140720150433.14617.99599 () probe ! kde ! org
[Download RAW message or body]

--===============0605583925791062115==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118616/
-----------------------------------------------------------

(Updated July 20, 2014, 3:04 p.m.)

Status
------

This change has been discarded.

Review request for Kate.

Repository: kate

Description
-------

This patch adds an action to the Kate component that allows the reloading of the \
syntax highlighting files.

Since I am not very familiar with the codebase I might have overlooked something, \
especially related to memory management.

Please let me know if I can improve the patch!

Diffs
-----

  part/syntax/katehighlight.h c2d4397e45d0dcba8fa5e822710cae8ea1643aee 
  part/syntax/katehighlight.cpp 7d956e53b0aee2a7fb5a636de18858a736c65ae4 
  part/view/kateview.h 6a522dabe4b1c9c96a8157abfb8716faba049234 
  part/view/kateview.cpp 5ede57e9af184c1f16098dadccec34211497d15a 

Diff: https://git.reviewboard.kde.org/r/118616/diff/

Testing
-------

I tested that the reloading works by editing the Markdown syntax highlighting file. \
After applying a change and reloading the file using the previously set shortcut, the \
highlighting changed correctly.

Thanks,

Christoph Rüßler

--===============0605583925791062115==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118616/">https://git.reviewboard.kde.org/r/118616/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Christoph Rüßler.</div>

<p style="color: grey;"><i>Updated July 20, 2014, 3:04 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds an action to the Kate component that allows the \
reloading of the syntax highlighting files.

Since I am not very familiar with the codebase I might have overlooked something, \
especially related to memory management.

Please let me know if I can improve the patch!</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested that the reloading works by editing the Markdown syntax \
highlighting file. After applying a change and reloading the file using the \
previously set shortcut, the highlighting changed correctly.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/syntax/katehighlight.h <span style="color: \
grey">(c2d4397e45d0dcba8fa5e822710cae8ea1643aee)</span></li>

 <li>part/syntax/katehighlight.cpp <span style="color: \
grey">(7d956e53b0aee2a7fb5a636de18858a736c65ae4)</span></li>

 <li>part/view/kateview.h <span style="color: \
grey">(6a522dabe4b1c9c96a8157abfb8716faba049234)</span></li>

 <li>part/view/kateview.cpp <span style="color: \
grey">(5ede57e9af184c1f16098dadccec34211497d15a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118616/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0605583925791062115==--

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 